| Message ID | 1524328891-3647-1-git-send-email-roopa@cumulusnetworks.com |
|---|---|
| Headers | show |
| Series | fib rules extack support | expand |
From: Roopa Prabhu <roopa@cumulusnetworks.com> Date: Sat, 21 Apr 2018 09:41:29 -0700 > From: Roopa Prabhu <roopa@cumulusnetworks.com> > > First patch refactors code to move fib rule netlink handling > into a common function. This became obvious when adding > duplicate extack msgs in add and del paths. Second patch > adds extack msgs. > > v2 - Dropped the ip route get support and selftests from > the series to look at the input path some more (as pointed > out by ido). Will come back to that next week when i have > some time. resending just the extack part for now. Series applied, but I was really looking forward to having those nice test cases in the tree. Thanks.
On Mon, Apr 23, 2018 at 7:21 AM, David Miller <davem@davemloft.net> wrote: > From: Roopa Prabhu <roopa@cumulusnetworks.com> > Date: Sat, 21 Apr 2018 09:41:29 -0700 > >> From: Roopa Prabhu <roopa@cumulusnetworks.com> >> >> First patch refactors code to move fib rule netlink handling >> into a common function. This became obvious when adding >> duplicate extack msgs in add and del paths. Second patch >> adds extack msgs. >> >> v2 - Dropped the ip route get support and selftests from >> the series to look at the input path some more (as pointed >> out by ido). Will come back to that next week when i have >> some time. resending just the extack part for now. > > Series applied, but I was really looking forward to having those > nice test cases in the tree. yes, am on it. (and also excited about my first selftest!) thanks (I just sent a follow-up bug fix for vrf).
From: Roopa Prabhu <roopa@cumulusnetworks.com> First patch refactors code to move fib rule netlink handling into a common function. This became obvious when adding duplicate extack msgs in add and del paths. Second patch adds extack msgs. v2 - Dropped the ip route get support and selftests from the series to look at the input path some more (as pointed out by ido). Will come back to that next week when i have some time. resending just the extack part for now. Roopa Prabhu (2): fib_rules: move common handling of newrule delrule msgs into fib_nl2rule net: fib_rules: add extack support include/net/fib_rules.h | 3 +- net/core/fib_rules.c | 471 +++++++++++++++++++++++------------------------- net/decnet/dn_rules.c | 7 +- net/ipv4/fib_rules.c | 7 +- net/ipv4/ipmr.c | 3 +- net/ipv6/fib6_rules.c | 7 +- net/ipv6/ip6mr.c | 3 +- 7 files changed, 245 insertions(+), 256 deletions(-)