diff mbox series

[mptcp-next] Squash to "mptcp: protect the rx path with the msk socket spinlock": a small cleanup

Message ID f34d3d0783b1daa26e3491ffb92a4b5096db76df.1606101185.git.geliangtang@gmail.com
State Accepted, archived
Commit 0439eb029552a072c0ee75483546e4fef6d0138a
Delegated to: Matthieu Baerts
Headers show
Series [mptcp-next] Squash to "mptcp: protect the rx path with the msk socket spinlock": a small cleanup | expand

Commit Message

Geliang Tang Nov. 23, 2020, 3:13 a.m. UTC
Since the local variable sk is defined, use it instead of open-coding.

Signed-off-by: Geliang Tang <geliangtang@gmail.com>
---
 net/mptcp/protocol.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Matthieu Baerts Nov. 25, 2020, 11:34 a.m. UTC | #1
Hi Geliang,

On 23/11/2020 04:13, Geliang Tang wrote:
> Since the local variable sk is defined, use it instead of open-coding.

Thank you for the cleanup!

- 0439eb029552: "squashed" in "mptcp: protect the rx path with the msk 
socket spinlock"
- 2fef4d92d6d7: "Signed-off-by" + "Co-developed-by"

Tests + export are in progress!

Cheers,
Matt
diff mbox series

Patch

diff --git a/net/mptcp/protocol.c b/net/mptcp/protocol.c
index e4bb41c02cc4..4a6e485dd22a 100644
--- a/net/mptcp/protocol.c
+++ b/net/mptcp/protocol.c
@@ -1869,7 +1869,7 @@  static bool __mptcp_move_skbs(struct mptcp_sock *msk, unsigned int rcv)
 		mptcp_data_unlock(sk);
 	}
 	if (ret)
-		mptcp_check_data_fin((struct sock *)msk);
+		mptcp_check_data_fin(sk);
 	return !skb_queue_empty(&msk->receive_queue);
 }