| Message ID | 24df6b98e251b2d67c25f12eb3c6c974aafa0101.1602241020.git.dcaratti@redhat.com |
|---|---|
| State | Accepted, archived |
| Commit | b61eb228f4a36ae0c481a0cb226cf7c77e109060 |
| Delegated to: | Matthieu Baerts |
| Headers | show |
| Series | [net-next] Squash-to: mptcp: refactor shutdown and close | expand |
Hi Davide, On 09/10/2020 12:57, Davide Caratti wrote: > the format specifier for 'write_seq' in __mptcp_check_send_data_fin() > should be the same as the one used for 'snd_nxt', to prevent humans > from becoming suddenly sad while inspecting the output of pr_debug(). > Change both 'snd_nxt' and 'write_seq' to be %llu. Thank you for the patch! - d98cacd423dc: "squashed" in "mptcp: refactor shutdown and close" - b61eb228f4a3: "Signed-off-by" + "Co-developed-by" Tests + export are going to be started soon! Cheers, Matt
diff --git a/net/mptcp/protocol.c b/net/mptcp/protocol.c index f8812097d63d..736a6481d20f 100644 --- a/net/mptcp/protocol.c +++ b/net/mptcp/protocol.c @@ -2033,7 +2033,7 @@ static void __mptcp_check_send_data_fin(struct sock *sk) struct mptcp_subflow_context *subflow; struct mptcp_sock *msk = mptcp_sk(sk); - pr_debug("msk=%p snd_data_fin_enable=%d pending=%d snd_nxt=%lld write_seq=%llx", + pr_debug("msk=%p snd_data_fin_enable=%d pending=%d snd_nxt=%llu write_seq=%llu", msk, msk->snd_data_fin_enable, !!mptcp_send_head(sk), msk->snd_nxt, msk->write_seq);
the format specifier for 'write_seq' in __mptcp_check_send_data_fin() should be the same as the one used for 'snd_nxt', to prevent humans from becoming suddenly sad while inspecting the output of pr_debug(). Change both 'snd_nxt' and 'write_seq' to be %llu. Signed-off-by: Davide Caratti <dcaratti@redhat.com> --- net/mptcp/protocol.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)