| Message ID | 20210116113653.3918024-1-matthieu.baerts@tessares.net |
|---|---|
| State | Accepted, archived |
| Commit | dd558b6560ca34ee39ee3154306ad9bc3093ad20 |
| Delegated to: | Matthieu Baerts |
| Headers | show |
| Series | [mptcp-next] Squash to "mptcp: drop *_max fields in mptcp_pm_data" | expand |
Hi On 16/01/2021 12:36, Matthieu Baerts wrote: > We need to export these functions that are also used in mptcp_diag.c > which can be part of a separated module. > > We can then avoid these errors: > > ERROR: modpost: "mptcp_pm_get_add_addr_accept_max" [net/mptcp/mptcp_diag.ko] undefined! > ERROR: modpost: "mptcp_pm_get_add_addr_signal_max" [net/mptcp/mptcp_diag.ko] undefined! > ERROR: modpost: "mptcp_pm_get_subflows_max" [net/mptcp/mptcp_diag.ko] undefined! This is now applied in our git repo. Cheers, Matt
Hi Matt, Matthieu Baerts <matthieu.baerts@tessares.net> 于2021年1月16日周六 下午7:49写道： > > Hi > > On 16/01/2021 12:36, Matthieu Baerts wrote: > > We need to export these functions that are also used in mptcp_diag.c > > which can be part of a separated module. > > > > We can then avoid these errors: > > > > ERROR: modpost: "mptcp_pm_get_add_addr_accept_max" [net/mptcp/mptcp_diag.ko] undefined! > > ERROR: modpost: "mptcp_pm_get_add_addr_signal_max" [net/mptcp/mptcp_diag.ko] undefined! > > ERROR: modpost: "mptcp_pm_get_subflows_max" [net/mptcp/mptcp_diag.ko] undefined! > > This is now applied in our git repo. > Thanks for this fix. -Geliang > Cheers, > Matt > -- > Tessares | Belgium | Hybrid Access Solutions > www.tessares.net > _______________________________________________ > mptcp mailing list -- mptcp@lists.01.org > To unsubscribe send an email to mptcp-leave@lists.01.org
diff --git a/net/mptcp/pm_netlink.c b/net/mptcp/pm_netlink.c index 42dd576c7b55..d03311b95112 100644 --- a/net/mptcp/pm_netlink.c +++ b/net/mptcp/pm_netlink.c @@ -203,6 +203,7 @@ unsigned int mptcp_pm_get_add_addr_signal_max(struct mptcp_sock *msk) pernet = net_generic(sock_net((struct sock *)msk), pm_nl_pernet_id); return READ_ONCE(pernet->add_addr_signal_max); } +EXPORT_SYMBOL_GPL(mptcp_pm_get_add_addr_signal_max); unsigned int mptcp_pm_get_add_addr_accept_max(struct mptcp_sock *msk) { @@ -211,6 +212,7 @@ unsigned int mptcp_pm_get_add_addr_accept_max(struct mptcp_sock *msk) pernet = net_generic(sock_net((struct sock *)msk), pm_nl_pernet_id); return READ_ONCE(pernet->add_addr_accept_max); } +EXPORT_SYMBOL_GPL(mptcp_pm_get_add_addr_accept_max); unsigned int mptcp_pm_get_local_addr_max(struct mptcp_sock *msk) { @@ -219,6 +221,7 @@ unsigned int mptcp_pm_get_local_addr_max(struct mptcp_sock *msk) pernet = net_generic(sock_net((struct sock *)msk), pm_nl_pernet_id); return READ_ONCE(pernet->local_addr_max); } +EXPORT_SYMBOL_GPL(mptcp_pm_get_local_addr_max); unsigned int mptcp_pm_get_subflows_max(struct mptcp_sock *msk) {
We need to export these functions that are also used in mptcp_diag.c which can be part of a separated module. We can then avoid these errors: ERROR: modpost: "mptcp_pm_get_add_addr_accept_max" [net/mptcp/mptcp_diag.ko] undefined! ERROR: modpost: "mptcp_pm_get_add_addr_signal_max" [net/mptcp/mptcp_diag.ko] undefined! ERROR: modpost: "mptcp_pm_get_subflows_max" [net/mptcp/mptcp_diag.ko] undefined! Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net> --- Notes: to be squashed in "mptcp: drop *_max fields in mptcp_pm_data" net/mptcp/pm_netlink.c | 3 +++ 1 file changed, 3 insertions(+)