| Message ID | 20201024101552.3707034-1-matthieu.baerts@tessares.net |
|---|---|
| State | Accepted, archived |
| Delegated to: | Matthieu Baerts |
| Headers | show |
| Series | [mptcp-next] Squash to "selftests: mptcp: add link failure test case" | expand |
Matthieu Baerts <matthieu.baerts@tessares.net> wrote: > Fix typo in files listed in the cleanup() function: $sin and $sout were > no longer removed at the end of the test. Indeed, thanks for fixing this.
Hi Florian, On 24/10/2020 14:19, Florian Westphal wrote: > Matthieu Baerts <matthieu.baerts@tessares.net> wrote: >> Fix typo in files listed in the cleanup() function: $sin and $sout were >> no longer removed at the end of the test. > > Indeed, thanks for fixing this. Thank you for the quick review! (now that I am thinking about that, I guess I don't really need reviews for such simple fixes :) ) - b2ef14a71ae1: Squash to "selftests: mptcp: add link failure test case" - Results: d13ebf3a735c..aafb67e19a3a Cheers, Matt
diff --git a/tools/testing/selftests/net/mptcp/mptcp_join.sh b/tools/testing/selftests/net/mptcp/mptcp_join.sh index 8b28c6cc038d..7ed2d8bdc9c0 100755 --- a/tools/testing/selftests/net/mptcp/mptcp_join.sh +++ b/tools/testing/selftests/net/mptcp/mptcp_join.sh @@ -82,7 +82,7 @@ cleanup_partial() cleanup() { rm -f "$cin" "$cout" - rm -f "$cin" "$cout" "$cinsent" + rm -f "$sin" "$sout" "$cinsent" cleanup_partial }
Fix typo in files listed in the cleanup() function: $sin and $sout were no longer removed at the end of the test. That's not a big issue, when finishing the script, $sin and $sout weight both 1KB. Fixes: 36221baa8712 ("selftests: mptcp: add link failure test case") Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net> --- Notes: to be squashed in "selftests: mptcp: add link failure test case" tools/testing/selftests/net/mptcp/mptcp_join.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)