| Message ID | 20200616165105.3015572-1-matthieu.baerts@tessares.net |
|---|---|
| State | Accepted, archived |
| Delegated to: | Matthieu Baerts |
| Headers | show |
| Series | [mptcp-next] mptcp: default KUNIT_* fragments to KUNIT_ALL_TESTS | expand |
On Tue, 16 Jun 2020, Matthieu Baerts wrote: > This makes it easier to enable all KUnit fragments. > > Adding 'if !KUNIT_ALL_TESTS so individual tests can not be turned off. > Therefore if KUNIT_ALL_TESTS is enabled that will hide the prompt in > menuconfig. > > Similar to beaed42c427d ("kunit: default KUNIT_* fragments to KUNIT_ALL_TESTS") > and following ones. > > Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net> > --- > > Notes: > to be squashed in "mptcp: move crypto test to KUNIT" > > net/mptcp/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/net/mptcp/Kconfig b/net/mptcp/Kconfig > index c701f27300ce..d7d5f9349366 100644 > --- a/net/mptcp/Kconfig > +++ b/net/mptcp/Kconfig > @@ -21,9 +21,10 @@ config MPTCP_IPV6 > endif > > config MPTCP_KUNIT_TESTS > - tristate "This builds the MPTCP KUnit tests" > + tristate "This builds the MPTCP KUnit tests" if !KUNIT_ALL_TESTS > select MPTCP > depends on KUNIT > + default KUNIT_ALL_TESTS > help > Currently covers the MPTCP crypto helpers. > Only useful for kernel devs running KUnit test harness and are not > -- > 2.27.0.rc0 Looks good to me, thanks Matthieu. -- Mat Martineau Intel
Hi Mat, On 19/06/2020 05:45, Mat Martineau wrote: > > On Tue, 16 Jun 2020, Matthieu Baerts wrote: > >> This makes it easier to enable all KUnit fragments. >> >> Adding 'if !KUNIT_ALL_TESTS so individual tests can not be turned off. >> Therefore if KUNIT_ALL_TESTS is enabled that will hide the prompt in >> menuconfig. >> >> Similar to beaed42c427d ("kunit: default KUNIT_* fragments to >> KUNIT_ALL_TESTS") >> and following ones. >> >> Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net> >> --- >> >> Notes: >> to be squashed in "mptcp: move crypto test to KUNIT" >> >> net/mptcp/Kconfig | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/net/mptcp/Kconfig b/net/mptcp/Kconfig >> index c701f27300ce..d7d5f9349366 100644 >> --- a/net/mptcp/Kconfig >> +++ b/net/mptcp/Kconfig >> @@ -21,9 +21,10 @@ config MPTCP_IPV6 >> endif >> >> config MPTCP_KUNIT_TESTS >> - tristate "This builds the MPTCP KUnit tests" >> + tristate "This builds the MPTCP KUnit tests" if !KUNIT_ALL_TESTS >> select MPTCP >> depends on KUNIT >> + default KUNIT_ALL_TESTS >> help >> Currently covers the MPTCP crypto helpers. >> Only useful for kernel devs running KUnit test harness and are not >> -- >> 2.27.0.rc0 > > Looks good to me, thanks Matthieu. Thank you for the review! Just applied: - 0868473a09ec: "squashed" in "mptcp: move crypto test to KUNIT" - e414c4e075c8: "Signed-off-by" + "Co-developed-by" - fadbf9fd17fc..7c2398e9940d: result Tests will be launched soon. Cheers, Matt
diff --git a/net/mptcp/Kconfig b/net/mptcp/Kconfig index c701f27300ce..d7d5f9349366 100644 --- a/net/mptcp/Kconfig +++ b/net/mptcp/Kconfig @@ -21,9 +21,10 @@ config MPTCP_IPV6 endif config MPTCP_KUNIT_TESTS - tristate "This builds the MPTCP KUnit tests" + tristate "This builds the MPTCP KUnit tests" if !KUNIT_ALL_TESTS select MPTCP depends on KUNIT + default KUNIT_ALL_TESTS help Currently covers the MPTCP crypto helpers. Only useful for kernel devs running KUnit test harness and are not
This makes it easier to enable all KUnit fragments. Adding 'if !KUNIT_ALL_TESTS so individual tests can not be turned off. Therefore if KUNIT_ALL_TESTS is enabled that will hide the prompt in menuconfig. Similar to beaed42c427d ("kunit: default KUNIT_* fragments to KUNIT_ALL_TESTS") and following ones. Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net> --- Notes: to be squashed in "mptcp: move crypto test to KUNIT" net/mptcp/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)