diff mbox series

.topmsg: tcp: clean ext on tx recycle

Message ID 20191213005822.29791-1-mathew.j.martineau@linux.intel.com
State Accepted, archived
Delegated to: Matthieu Baerts
Headers show
Series .topmsg: tcp: clean ext on tx recycle | expand

Commit Message

Mat Martineau Dec. 13, 2019, 12:58 a.m. UTC 
Reworded since the tree contains very little MPTCP code at this point
in the series.

Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
---
 .topmsg | 27 +++++++++++----------------
 1 file changed, 11 insertions(+), 16 deletions(-)

Comments

Matthieu Baerts Dec. 13, 2019, 4:38 p.m. UTC | #1 
On 13/12/2019 01:58, Mat Martineau wrote:
> Reworded since the tree contains very little MPTCP code at this point
> in the series.

Thank you for all the patches. I just applied all but I didn't modify 
the Signed-Off as I already did that. If I am not wrong, as a sender, 
your signed-off should be the last one, no?

- c7cb9c040948: "squahsed" patch 1/7 in "tcp: clean ext on tx recycle"
- 6719fc6e867d: "squashed" patch 2/7 in "mptcp: Handle MPTCP TCP options"
- d6a69af948b7: "squashed" patch 3/7 in "mptcp: Associate MPTCP context 
with TCP socket"
- 9e4d893cb81f: "squashed" patch 4/7 in "mptcp: Write MPTCP DSS headers 
to outgoing data packets"
- ae428c460335: "squashed" patch 5/7 in "mptcp: recvmsg() can drain data 
from multiple subflows"
- 0d182fc96c0b: "squashed" patch 6/7 in "mptcp: parse and emit 
MP_CAPABLE option according to v1 spec"
- 8d7da78ad705: "squashed" patch 7/7 in "mptcp: process MP_CAPABLE data 
option"

Cheers,
Matthieu
diff mbox series

Patch

diff --git a/.topmsg b/.topmsg
index 7aae16c9c23d..a8bca95438b4 100644
--- a/.topmsg
+++ b/.topmsg
@@ -1,26 +1,21 @@ 
 From: Paolo Abeni <pabeni@redhat.com>
 Subject: [PATCH] tcp: clean ext on tx recycle
 
-Otherwise we will find stray/unexpected/old extensions
-value on next iteration.
+Otherwise we will find stray/unexpected/old extensions value on next
+iteration.
 
-On tcp_write_xmit() we can end-up splitting an already queued
-skb in two parts, via tso_fragment(). The newly created skb
-can be allocated via the tx cache and the mptcp stack will not
-be aware of it, so nobody set properly the MPTCP ext.
+On tcp_write_xmit() we can end-up splitting an already queued skb in two
+parts, via tso_fragment(). The newly created skb can be allocated via
+the tx cache and an upper layer will not be aware of it, so that upper
+layer cannot set the ext properly.
 
-End result, we transmit the skb using an hold MPTCP DSS map
-and that confuses the rx side/corrupt the stream. It requires
-some concurrent conditions, so it's not deterministic.
+Resetting the ext on recycle ensures that stale data is not propagated
+in to packet headers or elsewhere.
 
-Resetting the ext on recycle fixes all the current mptcp self tests
-issues.
-
-Apparently only MPTCP has issues with this kind of stray ext,
-so an alternative would be add an additional mptcp hook in
-tso_fragment() or in sk_stream_alloc_skb() to always init
-the ext.
+An alternative would be add an additional hook in tso_fragment() or in
+sk_stream_alloc_skb() to init the ext for upper layers that need it.
 
 Co-developed-by: Florian Westphal <fw@strlen.de>
 Signed-off-by: Florian Westphal <fw@strlen.de>
+Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
 Signed-off-by: Paolo Abeni <pabeni@redhat.com>