From patchwork Sat Nov 16 12:59:34 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthieu Baerts X-Patchwork-Id: 1196107 X-Patchwork-Delegate: matthieu.baerts@tessares.net Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.01.org (client-ip=198.145.21.10; helo=ml01.01.org; envelope-from=mptcp-bounces@lists.01.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=tessares.net Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=tessares-net.20150623.gappssmtp.com header.i=@tessares-net.20150623.gappssmtp.com header.b="RRGfxneQ"; dkim-atps=neutral Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 47Fb0k0Dmmz9sNH for ; Sun, 17 Nov 2019 00:00:05 +1100 (AEDT) Received: from new-ml01.vlan13.01.org (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 429BB100DC3F4; Sat, 16 Nov 2019 05:01:19 -0800 (PST) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2a00:1450:4864:20::42e; helo=mail-wr1-x42e.google.com; envelope-from=matthieu.baerts@tessares.net; receiver= Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 50866100DC3F2 for ; Sat, 16 Nov 2019 05:01:17 -0800 (PST) Received: by mail-wr1-x42e.google.com with SMTP id w9so13938209wrr.0 for ; Sat, 16 Nov 2019 05:00:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tessares-net.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gA15bZbfYzDH0/fq6TBbRvDqXnzqRMora+IjTZSbo8M=; b=RRGfxneQYol+kOa0hKt3ycwpX9sZePQWbF8DoQO7ASw2JBn02kcfAWqeQtVCbNR8cM CwkXgKUtElwuz6MKEj6kTR6KFD9O6yB8YV4kzXbtB+Vv9XscLszy97oraKjHTp1uWxKk GYSjyK2Hj72EpGQixYKCsXFG/F9pOB9kT14HwRnBPyiglBKjoQ1aLL0B+XMQpc1dgd00 F1Pw809em/waoa9g8wObWkx/imgj5qksC7llKycnicW8NSrFU8osZV81m2i56bmxFehH I80CSbqFdcuz7OzrnmbM0Q45GtT2u1mOcrKVl24JYCiDbTgFYscbepFVBkNWLv2Ql1P2 aHPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gA15bZbfYzDH0/fq6TBbRvDqXnzqRMora+IjTZSbo8M=; b=RLM4R/Wq69kano4/SkBmaqJOTHfNB1yf2vrCoyWN1nw3CS+xWRgXxmeYxpL93EkZhv +FbRCMd24RQ+9YWF+mDpkJSFQTvD67wT+MYf7mfNQxdQi2Pl+PauIjBmXEmiRVyUVEZt iviYQIgSqizcSbarFT2Nq3w0I4Xz+g8T/lrakUGXqY/h0Sx0YCK9TU/6D9KCqfYodudj m7H5cWjVtxPajmpCUB8oKI+SeAQdc1i+LrB9stuqNHGsHb4ajQ8Vw43zdW1nczAosf14 IQNI6RUo+kGqz2QkCj6UgjJ7Cl3HLVA3uqElWjfaQKfGJ4ko+x/O4dsCDftntzREm54a VeFQ== X-Gm-Message-State: APjAAAUINIUddPoacMQ3pCtv3g81KOe1oG9+NwyeyuT7/lLtwz0O4S+/ zoONP1teHRjAmkXHz3/RHVLbi1jHbyKuqg== X-Google-Smtp-Source: APXvYqzgzKOEQn7yDBpLT8YtIbUB/O8RhzmY6j5LCiZ6RWRBQYVt9EtKC3/uqtxHsP9k/Cl3p9Do+w== X-Received: by 2002:adf:e506:: with SMTP id j6mr21210144wrm.19.1573909200706; Sat, 16 Nov 2019 05:00:00 -0800 (PST) Received: from tsr-vdi-mbaerts.nix.tessares.net (static.23.216.130.94.clients.your-server.de. [94.130.216.23]) by smtp.gmail.com with ESMTPSA id r15sm18381834wrc.5.2019.11.16.05.00.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 Nov 2019 05:00:00 -0800 (PST) From: Matthieu Baerts To: mptcp@lists.01.org Cc: Matthieu Baerts Date: Sat, 16 Nov 2019 13:59:34 +0100 Message-Id: <20191116125936.3563275-9-matthieu.baerts@tessares.net> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191116125936.3563275-1-matthieu.baerts@tessares.net> References: <20191116125936.3563275-1-matthieu.baerts@tessares.net> MIME-Version: 1.0 Message-ID-Hash: WRMZVK7HDSIW7YHISNCGMSCIEZIYH5V6 X-Message-ID-Hash: WRMZVK7HDSIW7YHISNCGMSCIEZIYH5V6 X-MailFrom: matthieu.baerts@tessares.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.1.1 Precedence: list Subject: [MPTCP] [PATCH 08/10] selftests:mptcp: do not reset "ret" when skipping List-Id: Discussions regarding MPTCP upstreaming Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: In the loop, we will have the two ns having the same name, that's normal. No need to return and error and reset ret to 0 (lret not modified, init to 0). Signed-off-by: Matthieu Baerts --- Notes: to be squashed in "mptcp: add basic kselftest for mptcp" tools/testing/selftests/net/mptcp/mptcp_connect.sh | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tools/testing/selftests/net/mptcp/mptcp_connect.sh b/tools/testing/selftests/net/mptcp/mptcp_connect.sh index a8c55005cc0c..1e2a24946e36 100755 --- a/tools/testing/selftests/net/mptcp/mptcp_connect.sh +++ b/tools/testing/selftests/net/mptcp/mptcp_connect.sh @@ -426,8 +426,7 @@ run_tests_lo() # skip if test programs are running inside same netns for subsequent runs. if [ $loopback -eq 0 ] && [ ${listener_ns} = ${connector_ns} ]; then - ret=$lret - return 1 + return 0 fi do_transfer ${listener_ns} ${connector_ns} MPTCP MPTCP ${connect_addr} ${local_addr}