From patchwork Sat Nov 16 12:59:29 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthieu Baerts X-Patchwork-Id: 1196112 X-Patchwork-Delegate: matthieu.baerts@tessares.net Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.01.org (client-ip=2001:19d0:306:5::1; helo=ml01.01.org; envelope-from=mptcp-bounces@lists.01.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=tessares.net Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=tessares-net.20150623.gappssmtp.com header.i=@tessares-net.20150623.gappssmtp.com header.b="MjWF80XV"; dkim-atps=neutral Received: from ml01.01.org (ml01.01.org [IPv6:2001:19d0:306:5::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 47Fb0m3g2hz9sPW for ; Sun, 17 Nov 2019 00:00:07 +1100 (AEDT) Received: from new-ml01.vlan13.01.org (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 0E988100DC3EA; Sat, 16 Nov 2019 05:01:15 -0800 (PST) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2a00:1450:4864:20::341; helo=mail-wm1-x341.google.com; envelope-from=matthieu.baerts@tessares.net; receiver= Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7D68B100DC3E2 for ; Sat, 16 Nov 2019 05:01:13 -0800 (PST) Received: by mail-wm1-x341.google.com with SMTP id t26so13351194wmi.4 for ; Sat, 16 Nov 2019 04:59:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tessares-net.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=IRkoyOrpb3jyURecy6Lp0/f2y8oA35kgBLeHD6RnNVw=; b=MjWF80XVKpxbmngyTcwDxVaZvjCB1we/hFVKH16JuWBXU3Tt1eqHoueVCLQEkG6QpN cYVe7GxrEvCVL8BcKAa5ayWlCS0wm1szF4l7rMp+e0gvS5dEGxsDC5YW1ltmX3CRJfoV 8tfIdoPtVvtTRunahwb5uos+eKdOA0U7cpZT39nuweCWuNn+nBKiRy3IlLFFLN12RIGi lByFRjG5AhPbfDJr7w4abo1ZkQGZXYGXsP97JHNbF23C9C7BHJC5d0vXzwdvoX4MX432 ne5iH/NF3CCx3Ess2hP9Vc1iAE0z78eFSw7FQI8WLzkJhgGllwCN5oEkMNP05eKvg74f UdOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=IRkoyOrpb3jyURecy6Lp0/f2y8oA35kgBLeHD6RnNVw=; b=qUzlFUcGFMSo7zpMRh1lDjz8V1AUc7o141GFjQw8gMwuSJdo7MU15t8vsAhAPRhNUX t9Hl+otyVNFkXKRv0664Q8ww92UUG97NzZoCf6510S0rQ3Lo18FjEjTQaE/MpymU1K83 vIFbtGbXGnXcaEn6QdO72iJ9S1Hz9QIJBsLilpVcO7CXpRFhi26LmaArRXJGvikN7Ji0 qQ0xxnlITOT9TS87vvn5u9p2ZrTCo16dCdMmdQl0hl1U1+79qOrfbWlqnElVjP80oLb7 d6N+mIvBFCLWOlxHR5IAVADAgHXw0U49V8NlPLZtG7cgtT6Zc8dcSa61DrnvBjpmaV0H +JIQ== X-Gm-Message-State: APjAAAUhgjVkDK2h0kCzlcEFQtJxUCxEnLlLPyqkIR826WNSxdPq/VKx vUsHAZxiAEZdp0rrvcC9z9/haZ3gOhdmXQ== X-Google-Smtp-Source: APXvYqxs/0Ln3ImPI+W2Qy1idEp99Qvw0bwebewB5NRYjgIk6ZedcAaT/IeeVvzcx3BpzZvliDRXRg== X-Received: by 2002:a05:600c:2944:: with SMTP id n4mr20189760wmd.57.1573909196905; Sat, 16 Nov 2019 04:59:56 -0800 (PST) Received: from tsr-vdi-mbaerts.nix.tessares.net (static.23.216.130.94.clients.your-server.de. [94.130.216.23]) by smtp.gmail.com with ESMTPSA id r15sm18381834wrc.5.2019.11.16.04.59.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 Nov 2019 04:59:56 -0800 (PST) From: Matthieu Baerts To: mptcp@lists.01.org Cc: Matthieu Baerts Date: Sat, 16 Nov 2019 13:59:29 +0100 Message-Id: <20191116125936.3563275-4-matthieu.baerts@tessares.net> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191116125936.3563275-1-matthieu.baerts@tessares.net> References: <20191116125936.3563275-1-matthieu.baerts@tessares.net> MIME-Version: 1.0 Message-ID-Hash: NQI4HYVM5TM5GJUKEAG6IEOISOKNF6ST X-Message-ID-Hash: NQI4HYVM5TM5GJUKEAG6IEOISOKNF6ST X-MailFrom: matthieu.baerts@tessares.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.1.1 Precedence: list Subject: [MPTCP] [PATCH 03/10] selftests:mptcp: align v4 and v6 results List-Id: Discussions regarding MPTCP upstreaming Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Now that v6 tests are enabled by default, it annoys me that the alignement is not OK :-) Also thanks to this new alignment, I found a strange issue that led to multiple tests and at the end a crash, see a separated email I sent. Now the IP:port messages look like that: (10.0.1.1:10000 ) (dead:beef:2::1:10029) But then the rest is aligned: # INFO: Using loss of 0.22% delay 150 ms reorder 94% 20% on ns3eth4 # ns1-5dcf183d-9ef7pp MPTCP -> ns1-5dcf183d-9ef7pp (10.0.1.1:10000 ) MPTCP (duration 128ms) [ OK ] # ns1-5dcf183d-9ef7pp MPTCP -> ns1-5dcf183d-9ef7pp (10.0.1.1:10001 ) TCP (duration 127ms) [ OK ] # ns1-5dcf183d-9ef7pp TCP -> ns1-5dcf183d-9ef7pp (10.0.1.1:10002 ) MPTCP (duration 110ms) [ OK ] # ns1-5dcf183d-9ef7pp MPTCP -> ns1-5dcf183d-9ef7pp (dead:beef:1::1:10003) MPTCP (duration 127ms) [ OK ] # ns1-5dcf183d-9ef7pp MPTCP -> ns1-5dcf183d-9ef7pp (dead:beef:1::1:10004) TCP (duration 113ms) [ OK ] # ns1-5dcf183d-9ef7pp TCP -> ns1-5dcf183d-9ef7pp (dead:beef:1::1:10005) MPTCP (duration 135ms) [ OK ] Signed-off-by: Matthieu Baerts --- Notes: to be squashed in "mptcp: add basic kselftest for mptcp" tools/testing/selftests/net/mptcp/mptcp_connect.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/net/mptcp/mptcp_connect.sh b/tools/testing/selftests/net/mptcp/mptcp_connect.sh index 49b3fb6b042d..74d62a69b6e9 100755 --- a/tools/testing/selftests/net/mptcp/mptcp_connect.sh +++ b/tools/testing/selftests/net/mptcp/mptcp_connect.sh @@ -302,7 +302,8 @@ do_transfer() :> "$sout" :> "$capout" - printf "%-4s %-5s -> %-4s (%s:%d) %-5s\t" ${connector_ns} ${cl_proto} ${listener_ns} ${connect_addr} ${port} ${srv_proto} + addr_port=$(printf "%s:%d" ${connect_addr} ${port}) + printf "%-4s %-5s -> %-4s (%-20s) %-5s\t" ${connector_ns} ${cl_proto} ${listener_ns} ${addr_port} ${srv_proto} if $capture; then if [ -z $SUDO_USER ] ; then