| Message ID | 1ab161c24f9027ce76b3483f025be8bbfa0c7667.1606899179.git.geliangtang@gmail.com |
|---|---|
| State | Accepted, archived |
| Commit | 0ebaa63b1d30edd35d65af21403fa8c0742241f9 |
| Delegated to: | Matthieu Baerts |
| Headers | show |
| Series | [mptcp-next] mptcp: use MPTCPOPT_HMAC_LEN macro | expand |
On Wed, 2 Dec 2020, Geliang Tang wrote: > Use the macro MPTCPOPT_HMAC_LEN instead of a constant in struct > mptcp_options_received. > > Signed-off-by: Geliang Tang <geliangtang@gmail.com> > --- > net/mptcp/protocol.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/mptcp/protocol.h b/net/mptcp/protocol.h > index 6933cdc2e605..4e922620ee56 100644 > --- a/net/mptcp/protocol.h > +++ b/net/mptcp/protocol.h > @@ -122,7 +122,7 @@ struct mptcp_options_received { > u32 token; > u32 nonce; > u64 thmac; > - u8 hmac[20]; > + u8 hmac[MPTCPOPT_HMAC_LEN]; > u8 join_id; > u8 use_map:1, > dsn64:1, > -- > 2.26.2 Looks good to me. Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com> -- Mat Martineau Intel
Hi Geliang, Mat, On 02/12/2020 09:54, Geliang Tang wrote: > Use the macro MPTCPOPT_HMAC_LEN instead of a constant in struct > mptcp_options_received. > > Signed-off-by: Geliang Tang <geliangtang@gmail.com> Thank you for the patch and the review! This patch has been applied after other patches from Geliang. - 0ebaa63b1d30: mptcp: use MPTCPOPT_HMAC_LEN macro - With Mat's tag - Results: 95b2727396d3..8e81e32d0db6 Tests + export are going to be started soon! Cheers, Matt
diff --git a/net/mptcp/protocol.h b/net/mptcp/protocol.h index 6933cdc2e605..4e922620ee56 100644 --- a/net/mptcp/protocol.h +++ b/net/mptcp/protocol.h @@ -122,7 +122,7 @@ struct mptcp_options_received { u32 token; u32 nonce; u64 thmac; - u8 hmac[20]; + u8 hmac[MPTCPOPT_HMAC_LEN]; u8 join_id; u8 use_map:1, dsn64:1,
Use the macro MPTCPOPT_HMAC_LEN instead of a constant in struct mptcp_options_received. Signed-off-by: Geliang Tang <geliangtang@gmail.com> --- net/mptcp/protocol.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)