mbox series

[v4,mptcp-next,0/5] add tracepoints

Message ID cover.1617175133.git.geliangtang@gmail.com
Headers show
Series add tracepoints | expand

Message

Geliang Tang March 31, 2021, 7:23 a.m. UTC 
v4:
 - add back patch 1.
 - use sk_fullsock in patch 2.

v3:
 - update the patch set as Paolo suggested.
 - drop the patch "mptcp: export mptcp_subflow_active".

v2:
 - add two new patches.

This patchset addressed issues 131, replace some/most pr_debug with trace
events. As Paolo suggested, we should add the tracepoints at "the packet
scheduler and the mapping status" first.

Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/131

Geliang Tang (5):
  mptcp: export mptcp_subflow_active
  mptcp: add tracepoint in mptcp_subflow_get_send
  mptcp: add tracepoint in get_mapping_status
  mptcp: add tracepoint in ack_update_msk
  mptcp: add tracepoint in subflow_check_data_avail

 include/trace/events/mptcp.h | 166 +++++++++++++++++++++++++++++++++++
 net/mptcp/options.c          |   6 ++
 net/mptcp/protocol.c         |  20 +----
 net/mptcp/protocol.h         |  12 +++
 net/mptcp/subflow.c          |  10 +--
 5 files changed, 192 insertions(+), 22 deletions(-)
 create mode 100644 include/trace/events/mptcp.h

Comments

Matthieu Baerts April 1, 2021, 4:21 p.m. UTC | #1 
Hi Geliang, Paolo,

On 31/03/2021 09:23, Geliang Tang wrote:
> v4:
>   - add back patch 1.
>   - use sk_fullsock in patch 2.
> 
> v3:
>   - update the patch set as Paolo suggested.
>   - drop the patch "mptcp: export mptcp_subflow_active".
> 
> v2:
>   - add two new patches.
> 
> This patchset addressed issues 131, replace some/most pr_debug with trace
> events. As Paolo suggested, we should add the tracepoints at "the packet
> scheduler and the mapping status" first.
> 
> Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/131

I already closed it, even if there is still one pending squash-to patch.

> Geliang Tang (5):
>    mptcp: export mptcp_subflow_active
>    mptcp: add tracepoint in mptcp_subflow_get_send
>    mptcp: add tracepoint in get_mapping_status
>    mptcp: add tracepoint in ack_update_msk
>    mptcp: add tracepoint in subflow_check_data_avail

Thank you for the patches and reviews!

Just applied in our tree with Paolo's ACK + a modification of the 
MAINTAINERS file in patch 2/5

- 00ed6f03febe: mptcp: export mptcp_subflow_active
- e4421bbffd09: mptcp: add tracepoint in mptcp_subflow_get_send
- 12abe4c31032: mptcp: add tracepoint in get_mapping_status
- 88a550c12ce4: mptcp: add tracepoint in ack_update_msk
- 769badb3d5a3: mptcp: add tracepoint in subflow_check_data_avail

Tests + export are in progress!

Cheers,
Matt