mbox series

[mptcp-next,0/3] mptcp: improve mptcp release callback

Message ID cover.1612869198.git.pabeni@redhat.com
Headers show
Series mptcp: improve mptcp release callback | expand

Message

Paolo Abeni Feb. 9, 2021, 11:42 a.m. UTC 
The current callback implementation is probe to some race
and still use some suboptimal code from older times.

This series clean-up the code a bit, fixing the race
and hopefully simplifying future wider usage of delegated
actions

Paolo Abeni (3):
  mptcp: factor out __mptcp_retrans helper()
  mptcp: fix race in release_cb
  mptcp: clean-up the rtx path.

 net/mptcp/protocol.c | 164 +++++++++++++++++++++----------------------
 net/mptcp/protocol.h |   1 +
 2 files changed, 81 insertions(+), 84 deletions(-)

Comments

Mat Martineau Feb. 10, 2021, 1:09 a.m. UTC | #1 
On Tue, 9 Feb 2021, Paolo Abeni wrote:

> The current callback implementation is probe to some race
> and still use some suboptimal code from older times.
>
> This series clean-up the code a bit, fixing the race
> and hopefully simplifying future wider usage of delegated
> actions
>
> Paolo Abeni (3):
>  mptcp: factor out __mptcp_retrans helper()
>  mptcp: fix race in release_cb
>  mptcp: clean-up the rtx path.
>
> net/mptcp/protocol.c | 164 +++++++++++++++++++++----------------------
> net/mptcp/protocol.h |   1 +
> 2 files changed, 81 insertions(+), 84 deletions(-)
>
> -- 
> 2.26.2

Thanks Paolo, series looks good:

Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>

--
Mat Martineau
Intel
Matthieu Baerts Feb. 10, 2021, 11:37 a.m. UTC | #2 
Hi Paolo, Mat,

On 09/02/2021 12:42, Paolo Abeni wrote:
> The current callback implementation is probe to some race
> and still use some suboptimal code from older times.
> 
> This series clean-up the code a bit, fixing the race
> and hopefully simplifying future wider usage of delegated
> actions
> 
> Paolo Abeni (3):
>    mptcp: factor out __mptcp_retrans helper()
>    mptcp: fix race in release_cb
>    mptcp: clean-up the rtx path.

Thank you for the patches and the reviews!

It is now in our tree without a dot at the end of the last patch' 
subject and Mat's RvB tags:

- 1a97b665b9ee: mptcp: factor out __mptcp_retrans helper()
- f1c293d570e1: mptcp: fix race in release_cb
- 711d7b99ea0a: mptcp: clean-up the rtx path
- Results: b72113120e91..9c096197d99f

Tests + export are all good!

Cheers,
Matt