mbox series

[v5,0/6] mptcp: just another complete datapath refactor

Message ID cover.1605789317.git.pabeni@redhat.com
Headers show
Series mptcp: just another complete datapath refactor | expand

Message

Paolo Abeni Nov. 19, 2020, 12:38 p.m. UTC 
This iteration introduces some improvement for the wake-up/poll code
as discussed on the ML.

The last 2 patches in the previous iterations has been merged in a single
one, with all the relevant deltas noted there.

Looking for merge now ;)

Paolo Abeni (6):
  mptcp: open code mptcp variant for lock_sock
  mptcp: implement wmem reservation.
  mptcp: protect the rx path with the msk socket spinlock
  mptcp: allocate TX skbs in msk context.
  mptcp: avoid a few atomic ops in the rx path
  mptcp: use mptcp release_cb for delayed tasks.

 net/core/sock.c        |   2 +-
 net/mptcp/mptcp_diag.c |   2 +-
 net/mptcp/options.c    |  47 +--
 net/mptcp/protocol.c   | 734 ++++++++++++++++++++++++++++++-----------
 net/mptcp/protocol.h   |  36 +-
 net/mptcp/subflow.c    |  14 +-
 6 files changed, 600 insertions(+), 235 deletions(-)

Comments

Matthieu Baerts Nov. 19, 2020, 5:07 p.m. UTC | #1 
Hi Paolo, Florian, Mat,

On 19/11/2020 13:38, Paolo Abeni wrote:
> This iteration introduces some improvement for the wake-up/poll code
> as discussed on the ML.
> 
> The last 2 patches in the previous iterations has been merged in a single
> one, with all the relevant deltas noted there.
> 
> Looking for merge now ;)

Done!

Thank you for your patches and reviews!

I just applied these patches in our tree after having fixed a few 
checkpatch issues (only related to codespell), remove "." at the end of 
the commit title, resolved one conflict with the patch (6/6) due to 
"mptcp: update rtx timeout only if required." patch applied earlier 
today and add Florian's Acked-by.

@Mat: please tell me if you want me to add your Reviewed-by tags on 
these ones ;-)

  - ea8e2035dfab: mptcp: open code mptcp variant for lock_sock
  - 8983b6ddc2a0: mptcp: implement wmem reservation
  - 44bb6c6d4e7f: mptcp: protect the rx path with the msk socket spinlock
  - 3a54a74a3c5b: mptcp: allocate TX skbs in msk context
  - 7ca128e90452: mptcp: avoid a few atomic ops in the rx path
  - 6b142355778a: mptcp: use mptcp release_cb for delayed tasks

  - Results: 55b2596bdf31..11818af71ea2

Tests + export are in progress.

Note that I already updated the export branch manually 
(export/20201119T175232) to let Christoph already starting some tests 
with syzkaller.

Cheers,
Matt