mbox series

[v7,mptcp-next,0/4] add ADD_ADDR echo flag support

Message ID cover.1598598749.git.geliangtang@gmail.com
Headers show
Series add ADD_ADDR echo flag support | expand

Message

Geliang Tang Aug. 28, 2020, 7:16 a.m. UTC 
v7:
 - add accept_subflow re-check

v6:
 - add "drop re-check mechanism for PM's flags"

v5:
 - move READ_ONCE(msk->pm.add_addr_echo) into mptcp_pm_add_addr_signal
 - move mptcp_pm_announce_addr into mptcp_pm_nl_add_addr_received and
   mptcp_pm_add_addr_received

v4:
 - Just updated some log messages in mptcp_join.sh

v3:
 - move add_addr_echo into mptcp_pm_announce_addr()
 - check return value of mptcp_pm_add_add_received
 - hold lock for add_addr_echo writing

v2:
 - add ADD_ADDR mibs
 - add selftests for ADD_ADDR

v1:
 - mptcp: send out ADD_ADDR with echo flag

Geliang Tang (4):
  mptcp: send out ADD_ADDR with echo flag
  mptcp: add ADD_ADDR related mibs
  selftests: mptcp: add ADD_ADDR mibs check function
  mptcp: add accept_subflow re-check

 net/mptcp/mib.c                               |  2 +
 net/mptcp/mib.h                               |  2 +
 net/mptcp/options.c                           | 34 +++++++++-----
 net/mptcp/pm.c                                | 28 ++++++------
 net/mptcp/pm_netlink.c                        |  4 +-
 net/mptcp/protocol.h                          |  6 ++-
 .../testing/selftests/net/mptcp/mptcp_join.sh | 44 +++++++++++++++++++
 7 files changed, 92 insertions(+), 28 deletions(-)

Comments

Mat Martineau Sept. 1, 2020, 12:26 a.m. UTC | #1 
On Fri, 28 Aug 2020, Geliang Tang wrote:

> v7:
> - add accept_subflow re-check
>

Hi Geliang -

v7 looks good to add to the export branch, thank you for the changes.


Mat



> v6:
> - add "drop re-check mechanism for PM's flags"
>
> v5:
> - move READ_ONCE(msk->pm.add_addr_echo) into mptcp_pm_add_addr_signal
> - move mptcp_pm_announce_addr into mptcp_pm_nl_add_addr_received and
>   mptcp_pm_add_addr_received
>
> v4:
> - Just updated some log messages in mptcp_join.sh
>
> v3:
> - move add_addr_echo into mptcp_pm_announce_addr()
> - check return value of mptcp_pm_add_add_received
> - hold lock for add_addr_echo writing
>
> v2:
> - add ADD_ADDR mibs
> - add selftests for ADD_ADDR
>
> v1:
> - mptcp: send out ADD_ADDR with echo flag
>
> Geliang Tang (4):
>  mptcp: send out ADD_ADDR with echo flag
>  mptcp: add ADD_ADDR related mibs
>  selftests: mptcp: add ADD_ADDR mibs check function
>  mptcp: add accept_subflow re-check
>
> net/mptcp/mib.c                               |  2 +
> net/mptcp/mib.h                               |  2 +
> net/mptcp/options.c                           | 34 +++++++++-----
> net/mptcp/pm.c                                | 28 ++++++------
> net/mptcp/pm_netlink.c                        |  4 +-
> net/mptcp/protocol.h                          |  6 ++-
> .../testing/selftests/net/mptcp/mptcp_join.sh | 44 +++++++++++++++++++
> 7 files changed, 92 insertions(+), 28 deletions(-)
>
> -- 
> 2.17.1
> _______________________________________________
> mptcp mailing list -- mptcp@lists.01.org
> To unsubscribe send an email to mptcp-leave@lists.01.org
>

--
Mat Martineau
Intel
Matthieu Baerts Sept. 4, 2020, 3:48 p.m. UTC | #2 
Hi Geliang, Mat,

On 01/09/2020 02:26, Mat Martineau wrote:
> 
> On Fri, 28 Aug 2020, Geliang Tang wrote:
> 
>> v7:
>> - add accept_subflow re-check
>>
> 
> v7 looks good to add to the export branch, thank you for the changes.

Thank you for the patches and the review!

Just added in the tree just after your 3 previous patches related to 
RM_ADDR. Because of that, I had 2 simple conflicts before of the 
modifications in the MIB:

   - e864f2897303: conflict in t/mptcp-add-OoO-related-mibs

I also added Mat's Reviewed-by.

Tests + export are in progress.

Cheers,
Matt