From patchwork Wed Nov 13 08:00:17 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Abeni X-Patchwork-Id: 1194114 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.01.org (client-ip=198.145.21.10; helo=ml01.01.org; envelope-from=mptcp-bounces@lists.01.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.b="cg+rmEiB"; dkim-atps=neutral Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 47CcWr2qpyz9sPc for ; Wed, 13 Nov 2019 19:01:43 +1100 (AEDT) Received: from new-ml01.vlan13.01.org (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 27333100DC422; Wed, 13 Nov 2019 00:03:20 -0800 (PST) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=205.139.110.61; helo=us-smtp-delivery-1.mimecast.com; envelope-from=pabeni@redhat.com; receiver= Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 223D3100EA622 for ; Wed, 13 Nov 2019 00:03:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573632096; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=C2dJArXixNCfh7zVnU7on1eSauRo166zePZYO7Zb6bM=; b=cg+rmEiBTLB+yW+8c0mRQeiI/gVuNYRT7UDJ4bLrON43g76hD8uyVDB5PmofmQpHHD/NWd vN8spAQkHzUjcDE7Ub6UzmOpkgOL0U6x6bfBr95Io0LYYFJrLEWaBM86xJiX/eK1DMc4C2 iGFHWe6+2lGA+xgjxfgZSpXvwJ3BGPg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-332-1-CdzVVfMfSuAvgzMA4nYg-1; Wed, 13 Nov 2019 03:01:33 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6CEBD477 for ; Wed, 13 Nov 2019 08:01:32 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-117-57.ams2.redhat.com [10.36.117.57]) by smtp.corp.redhat.com (Postfix) with ESMTP id D12AD60251 for ; Wed, 13 Nov 2019 08:01:31 +0000 (UTC) From: Paolo Abeni To: mptcp@lists.01.org Date: Wed, 13 Nov 2019 09:00:17 +0100 Message-Id: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: 1-CdzVVfMfSuAvgzMA4nYg-1 X-Mimecast-Spam-Score: 0 Message-ID-Hash: 2JOUZYLT3T7GADVKDDTS2GYZYZHSSI63 X-Message-ID-Hash: 2JOUZYLT3T7GADVKDDTS2GYZYZHSSI63 X-MailFrom: pabeni@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.1.1 Precedence: list Subject: [MPTCP] [PATCH v2 0/4] mptcp: disable mptcp when md5sig is set List-Id: Discussions regarding MPTCP upstreaming Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: As per last public mtg discussion, md5sig will cause TCP option space exaustion. Without md5sig we can't exhaust the TCP option space. This series explcitly disable MPTCP when md5sig is set, and cleanup later option len checks with the assumption that TCP option space exhaustion is not expected - add a single WARN_ON() for that. v1 -> v2: - fix a couple of typos in comment/commit messages Paolo Abeni (4): mptcp: move mp_capable initialization at subflow_init_req() start mptcp: disable on req sk if MD5SIG is enabled mptcp: warn once if exceeding tcp opt space for dss/mp_capable mptcp: remove unneeded check in mptcp_established_options_mp() net/mptcp/subflow.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)