mbox series

[mptcp-next,0/3] Squash to "selftests: mptcp: add a test case for MSG_PEEK"

Message ID 20210419203355.3937162-1-matthieu.baerts@tessares.net
Headers show
Series Squash to "selftests: mptcp: add a test case for MSG_PEEK" | expand

Message

Matthieu Baerts April 19, 2021, 8:33 p.m. UTC 
I started this because I prefer avoiding setting a global variable before
calling a function and reset it later in order to take a specific path in the
called function. While at it, I also reduced duplicated code.

But good thing, I also fixed two unwanted behaviours, see patches 1/3 and 2/3.

Matthieu Baerts (3):
  selftests: mptcp: use 2 different 'peek' modes
  selftests: mptcp: same NS for Peek tests in IPv6
  selftests: mptcp: avoid non-const global variables

 .../selftests/net/mptcp/mptcp_connect.sh      | 44 +++++++++----------
 1 file changed, 22 insertions(+), 22 deletions(-)

Comments

Mat Martineau April 19, 2021, 10:28 p.m. UTC | #1 
On Mon, 19 Apr 2021, Matthieu Baerts wrote:

> I started this because I prefer avoiding setting a global variable before
> calling a function and reset it later in order to take a specific path in the
> called function. While at it, I also reduced duplicated code.
>
> But good thing, I also fixed two unwanted behaviours, see patches 1/3 and 2/3.
>
> Matthieu Baerts (3):
>  selftests: mptcp: use 2 different 'peek' modes
>  selftests: mptcp: same NS for Peek tests in IPv6
>  selftests: mptcp: avoid non-const global variables
>
> .../selftests/net/mptcp/mptcp_connect.sh      | 44 +++++++++----------
> 1 file changed, 22 insertions(+), 22 deletions(-)
>
> -- 
> 2.30.2

Hi Matthieu -

These look good to squash, thanks for the fixups!


--
Mat Martineau
Intel
Matthieu Baerts April 20, 2021, 7:48 a.m. UTC | #2 
Hi Mat,

On 20/04/2021 00:28, Mat Martineau wrote:
> On Mon, 19 Apr 2021, Matthieu Baerts wrote:
> 
>> I started this because I prefer avoiding setting a global variable before
>> calling a function and reset it later in order to take a specific path
>> in the
>> called function. While at it, I also reduced duplicated code.
>>
>> But good thing, I also fixed two unwanted behaviours, see patches 1/3
>> and 2/3.
> 
> Hi Matthieu -
> 
> These look good to squash, thanks for the fixups!

Thank you for your review!

I just added these patches in our tree and I added your RvB tag to the
patch "selftests: mptcp: add a test case for MSG_PEEK". I hope that's
alright. I can remove it if you prefer. I guess you will replace it with
your SoB when sending them anyway :)

- 56b3332ce650: "squashed" patch 1/3 in "selftests: mptcp: add a test
case for MSG_PEEK"
- 2c2ca30de1d6: "Signed-off-by" + "Co-developed-by"
- 7d6c15c30c4c: "squashed" patch 2/3 in "selftests: mptcp: add a test
case for MSG_PEEK"
- 739a1c5fe1d6: "squashed" patch 3/3 in "selftests: mptcp: add a test
case for MSG_PEEK"
- ebcf2d3b0e42: tg:msg: add Mat's RvB tag
- Results: 04c5ff771be8..e69889ce0094

Tests + export are in progress!

Cheers,
Matt