| Message ID | 20200624192448.20837-1-fw@strlen.de |
|---|---|
| Headers | show |
| Series | setsockopt: allow reuseport and ip6only | expand |
On Wed, 24 Jun 2020, Florian Westphal wrote: > 3rd iteration. I've incorporated feedback from Mat, so for > options other than reuseport/reuseaddr the generic handler gets called > instead of returning -EOPNOTSUPP. > > I've tested that ssh restart works on a a modified kernel that > enables mptcp for all IPPROTO_TCP sockets. Thanks for the v3 updates, changes look good. Should the patches go to the mptcp repo for some more test coverage or are you intending to post for net-next soon? -- Mat Martineau Intel
Mat Martineau <mathew.j.martineau@linux.intel.com> wrote: > > On Wed, 24 Jun 2020, Florian Westphal wrote: > > > 3rd iteration. I've incorporated feedback from Mat, so for > > options other than reuseport/reuseaddr the generic handler gets called > > instead of returning -EOPNOTSUPP. > > > > I've tested that ssh restart works on a a modified kernel that > > enables mptcp for all IPPROTO_TCP sockets. > > Thanks for the v3 updates, changes look good. Should the patches go to the > mptcp repo for some more test coverage or are you intending to post for > net-next soon? The former, they depend on Paolos fallback refactoring which isn't in net-next yet afaics.
On Thu, 2020-06-25 at 00:46 +0200, Florian Westphal wrote: > Mat Martineau <mathew.j.martineau@linux.intel.com> wrote: > > On Wed, 24 Jun 2020, Florian Westphal wrote: > > > > > 3rd iteration. I've incorporated feedback from Mat, so for > > > options other than reuseport/reuseaddr the generic handler gets called > > > instead of returning -EOPNOTSUPP. > > > > > > I've tested that ssh restart works on a a modified kernel that > > > enables mptcp for all IPPROTO_TCP sockets. > > > > Thanks for the v3 updates, changes look good. Should the patches go to the > > mptcp repo for some more test coverage or are you intending to post for > > net-next soon? > > The former, they depend on Paolos fallback refactoring which isn't in > net-next yet afaics. I'd like to spool the token refactor first, which in turn will cause conflict without "mptcp: drop MP_JOIN request sock on syn cookies" - currently on -net only. I'll ask Dave for a -net -> -net-next merge, so we can start spooling stuff. Cheers, Paolo
Hi Florian, Mat, Paolo, On 25/06/2020 10:59, Paolo Abeni wrote: > On Thu, 2020-06-25 at 00:46 +0200, Florian Westphal wrote: >> Mat Martineau <mathew.j.martineau@linux.intel.com> wrote: >>> On Wed, 24 Jun 2020, Florian Westphal wrote: >>> >>>> 3rd iteration. I've incorporated feedback from Mat, so for >>>> options other than reuseport/reuseaddr the generic handler gets called >>>> instead of returning -EOPNOTSUPP. >>>> >>>> I've tested that ssh restart works on a a modified kernel that >>>> enables mptcp for all IPPROTO_TCP sockets. >>> >>> Thanks for the v3 updates, changes look good. Should the patches go to the >>> mptcp repo for some more test coverage or are you intending to post for >>> net-next soon? >> >> The former, they depend on Paolos fallback refactoring which isn't in >> net-next yet afaics. > > I'd like to spool the token refactor first, which in turn will cause > conflict without "mptcp: drop MP_JOIN request sock on syn cookies" - > currently on -net only. > > I'll ask Dave for a -net -> -net-next merge, so we can start spooling > stuff. Thank you for the patches and the reviews! I just added the patches at the end of the series. - 5433a4ffa2d6: net: use mptcp setsockopt function for SOL_SOCKET on mptcp sockets - 681584082eab: mptcp: add REUSEADDR/REUSEPORT support - cffa48f64125: mptcp: support IPV6_V6ONLY setsockopt Tests + export are in progress. Cheers, Matt