mbox series

[00/10] selftests: IPv6 by default and time reduction

Message ID 20191116125936.3563275-1-matthieu.baerts@tessares.net
Headers show
Series selftests: IPv6 by default and time reduction | expand

Message

Matthieu Baerts Nov. 16, 2019, 12:59 p.m. UTC 
Here are a few improvements in the selftests. Nothing complex, some
details to have the results more readable (I think), IPv6 enabled by
default, the time of the execution is reduced (around 30 seconds now
with the same launched tests), and the script is more robust for the
future.

I hope we can apply the one before the last one: IPV6 is now forced in
the config, we can then always apply the IPv6 network config and remove
a lot of 'if $ipv6' in the code.

For the last one, I guess we should not apply it now because some tests
are really slow in some conditions. More details in the patch and a
separated email has been sent.

All the patches can be squashed in the commit introducing the selftests:

  mptcp: add basic kselftest for mptcp

Matthieu Baerts (10):
  selftests:mptcp: fix typo
  selftests:mptcp: enable v6 by default
  selftests:mptcp: align v4 and v6 results
  selftests:mptcp: reduce wait time for the listen
  selftests:mptcp: reduce time to wait for DAD
  selftests:mptcp: only display the NS id
  selftests:mptcp: avoid global var clash
  selftests:mptcp: do not reset "ret" when skipping
  selftests:mptcp: force MPTCP_IPV6 config
  [RFC] selftests:mptcp: decrease timeout to 100 sec

 tools/testing/selftests/net/mptcp/config      |   1 +
 .../selftests/net/mptcp/mptcp_connect.sh      | 245 +++++++++++-------
 tools/testing/selftests/net/mptcp/settings    |   2 +-
 3 files changed, 147 insertions(+), 101 deletions(-)

Comments

Florian Westphal Nov. 16, 2019, 1:41 p.m. UTC | #1 
Matthieu Baerts <matthieu.baerts@tessares.net> wrote:
> Here are a few improvements in the selftests. Nothing complex, some
> details to have the results more readable (I think), IPv6 enabled by
> default, the time of the execution is reduced (around 30 seconds now
> with the same launched tests), and the script is more robust for the
> future.
> 
> I hope we can apply the one before the last one: IPV6 is now forced in
> the config, we can then always apply the IPv6 network config and remove
> a lot of 'if $ipv6' in the code.
> 
> For the last one, I guess we should not apply it now because some tests
> are really slow in some conditions. More details in the patch and a
> separated email has been sent.
> 
> All the patches can be squashed in the commit introducing the selftests:
> 
>   mptcp: add basic kselftest for mptcp

These look good, thanks Matthieu.
Matthieu Baerts Nov. 20, 2019, 4:07 p.m. UTC | #2 
Hi Florian,

On 16/11/2019 14:41, Florian Westphal wrote:
> Matthieu Baerts <matthieu.baerts@tessares.net> wrote:
>> Here are a few improvements in the selftests. Nothing complex, some
>> details to have the results more readable (I think), IPv6 enabled by
>> default, the time of the execution is reduced (around 30 seconds now
>> with the same launched tests), and the script is more robust for the
>> future.
>>
>> I hope we can apply the one before the last one: IPV6 is now forced in
>> the config, we can then always apply the IPv6 network config and remove
>> a lot of 'if $ipv6' in the code.
>>
>> For the last one, I guess we should not apply it now because some tests
>> are really slow in some conditions. More details in the patch and a
>> separated email has been sent.
>>
>> All the patches can be squashed in the commit introducing the selftests:
>>
>>    mptcp: add basic kselftest for mptcp
> 
> These look good, thanks Matthieu.

Thank you for your review!

I just "squashed" all these patches *except* the last one in "mptcp: add 
basic kselftest for mptcp".

eb9de3c3e89b..84af4075aa4f: result

Cheers,
Matt