Message ID | 20191116125936.3563275-1-matthieu.baerts@tessares.net |
---|---|
Headers | show |
Series | selftests: IPv6 by default and time reduction | expand |
Matthieu Baerts <matthieu.baerts@tessares.net> wrote: > Here are a few improvements in the selftests. Nothing complex, some > details to have the results more readable (I think), IPv6 enabled by > default, the time of the execution is reduced (around 30 seconds now > with the same launched tests), and the script is more robust for the > future. > > I hope we can apply the one before the last one: IPV6 is now forced in > the config, we can then always apply the IPv6 network config and remove > a lot of 'if $ipv6' in the code. > > For the last one, I guess we should not apply it now because some tests > are really slow in some conditions. More details in the patch and a > separated email has been sent. > > All the patches can be squashed in the commit introducing the selftests: > > mptcp: add basic kselftest for mptcp These look good, thanks Matthieu.
Hi Florian, On 16/11/2019 14:41, Florian Westphal wrote: > Matthieu Baerts <matthieu.baerts@tessares.net> wrote: >> Here are a few improvements in the selftests. Nothing complex, some >> details to have the results more readable (I think), IPv6 enabled by >> default, the time of the execution is reduced (around 30 seconds now >> with the same launched tests), and the script is more robust for the >> future. >> >> I hope we can apply the one before the last one: IPV6 is now forced in >> the config, we can then always apply the IPv6 network config and remove >> a lot of 'if $ipv6' in the code. >> >> For the last one, I guess we should not apply it now because some tests >> are really slow in some conditions. More details in the patch and a >> separated email has been sent. >> >> All the patches can be squashed in the commit introducing the selftests: >> >> mptcp: add basic kselftest for mptcp > > These look good, thanks Matthieu. Thank you for your review! I just "squashed" all these patches *except* the last one in "mptcp: add basic kselftest for mptcp". eb9de3c3e89b..84af4075aa4f: result Cheers, Matt