| Message ID | trinity-73a44add-26d5-4c8b-b6ad-0576beafb79a-1715202092298@3c-app-webde-bap44 |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | open_posix_testsuite: Remove inclomplete warning commandline argument | expand |
Hi! > The Open Posix testsuite calls the compiler with the commandline argument > "-W", but that is not a supported gcc warning option > and breaks other compiler. > > This patch removes the broken "-W" commandline argument. Isn't -W old name for -Wextra?
Hi, Am 5/9/2024 um 11:21 AM schrieb Cyril Hrubis: > Hi! >> The Open Posix testsuite calls the compiler with the commandline argument >> "-W", but that is not a supported gcc warning option >> and breaks other compiler. >> >> This patch removes the broken "-W" commandline argument. > > Isn't -W old name for -Wextra? exactly that is what gcc and clang documentation states. On top of that Additionally it is nothing introduced by 8071ba7, but already by ff4e69314c1 back in 2013 by no one else but you Cyril ;) I guess changing it to -Wextra wouldn't hurt and is what gcc recommends. Jörg
Hi all, > Hi, > Am 5/9/2024 um 11:21 AM schrieb Cyril Hrubis: > > Hi! > >> The Open Posix testsuite calls the compiler with the commandline argument > >> "-W", but that is not a supported gcc warning option > >> and breaks other compiler. > >> This patch removes the broken "-W" commandline argument. > > Isn't -W old name for -Wextra? > exactly that is what gcc and clang documentation states. > On top of that > Additionally it is nothing introduced by 8071ba7, but already by > ff4e69314c1 back in 2013 by no one else but you Cyril ;) Yes, it should be: Fixes: ff4e69314 ("open_posix_testsuite: Enable warnings.") > I guess changing it to -Wextra wouldn't hurt and is what gcc recommends. +1 for replacing -W with -Wextra FYI if we are interested what is behind -Wextra https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-W https://github.com/llvm-mirror/clang/blob/master/include/clang/Basic/DiagnosticGroups.td Kind regards, Petr > Jörg
Hi!
> +1 for replacing -W with -Wextra
Let's go with that -Wextra has been out there for long enough.
Hi Detlef, > Hi! > > +1 for replacing -W with -Wextra > Let's go with that -Wextra has been out there for long enough. Will you please send v2 and --cc us? Kind regards, Petr
diff --git a/testcases/open_posix_testsuite/include/mk/config.mk.in b/testcases/open_posix_testsuite/include/mk/config.mk.in index c9a4b5c5a..a43de6641 100644 --- a/testcases/open_posix_testsuite/include/mk/config.mk.in +++ b/testcases/open_posix_testsuite/include/mk/config.mk.in @@ -14,4 +14,4 @@ testdir_rel := @testdir@ testdir := ${prefix}/${testdir_rel} testdir_bin := ${testdir}/bin -CFLAGS += -std=c99 -D_POSIX_C_SOURCE=200809L -D_XOPEN_SOURCE=700 -W -Wall +CFLAGS += -std=c99 -D_POSIX_C_SOURCE=200809L -D_XOPEN_SOURCE=700 -Wall
The Open Posix testsuite calls the compiler with the commandline argument "-W", but that is not a supported gcc warning option and breaks other compiler. This patch removes the broken "-W" commandline argument. Fixes commit 8071ba7 References: https://gcc.gnu.org/onlinedocs/gcc/Option-Summary.html https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html -- Regards ... Detlef Signed-off-by: Detlef Riekenberg <wine.dev@web.de> --- testcases/open_posix_testsuite/include/mk/config.mk.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.40.1