From patchwork Thu Apr 10 21:22:11 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "sowmya.indranna--- via ltp" X-Patchwork-Id: 2071353 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=lists.linux.it header.i=@lists.linux.it header.a=rsa-sha256 header.s=picard header.b=BQpPZ8R4; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gd-ms.com header.i=@gd-ms.com header.a=rsa-sha256 header.s=esa header.b=sggXL3os; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it (client-ip=213.254.12.146; helo=picard.linux.it; envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it; receiver=patchwork.ozlabs.org) Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4ZYp9845smz1yJ4 for ; Fri, 11 Apr 2025 17:24:44 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=lists.linux.it; i=@lists.linux.it; q=dns/txt; s=picard; t=1744356301; h=to : date : message-id : mime-version : subject : list-id : list-unsubscribe : list-archive : list-post : list-help : list-subscribe : from : reply-to : content-type : content-transfer-encoding : sender : from; bh=ZT42cO6H0INRpoMDTn2nArDFt9wX8jk0n2LBBLW+CGg=; b=BQpPZ8R4uC88FrqPIaI/G95cmRo6/pvR9RGDmNPIYoAGCSMxk8ec7SC0q1bCLWSvko4O6 yJXJtfmb0mjbzc/uhE02clxOzxzZs/WidKXqoASKcgujbwImC5TIUxqicPFj0oZjiW9s8v4 mYjAlGhitl9HkI0w1X998NuQu1fmgIk= Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 73C4E3CB355 for ; Fri, 11 Apr 2025 09:25:01 +0200 (CEST) X-Original-To: ltp@lists.linux.it Delivered-To: ltp@picard.linux.it Received: from in-6.smtp.seeweb.it (in-6.smtp.seeweb.it [IPv6:2001:4b78:1:20::6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 4A8A63CABDF for ; Thu, 10 Apr 2025 23:22:18 +0200 (CEST) Authentication-Results: in-6.smtp.seeweb.it; spf=pass (sender SPF authorized) smtp.mailfrom=gd-ms.com (client-ip=137.100.132.43; helo=vadc01-egs01.gd-ms.com; envelope-from=john.morin@gd-ms.com; receiver=lists.linux.it) Received: from vadc01-egs01.gd-ms.com (vadc01-egs01.gd-ms.com [137.100.132.43]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-6.smtp.seeweb.it (Postfix) with ESMTPS id AAAB3140004B for ; Thu, 10 Apr 2025 23:22:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=gd-ms.com; i=@gd-ms.com; q=dns/txt; s=esa; t=1744320136; x=1775856136; h=from:to:subject:date:message-id:mime-version; bh=Y7uxw5tzn5VNuERdTmFQiUoFF0G1w7z9ORwWDv7xWwM=; b=sggXL3oshXi8CpddHErKu4Iauj7kSWBaJkNdL1Mmjii693yoZgfOy/3J pq4pMYGofs0rzqu7RsOAYKbSQR1zoGshW4DuDwySpaKAURW35ELsW0r7L 6ovG3kRbRyQyZ1DSf68WdYkk6WZaYIyzKtIoqhVYj8ar5WDTmWVjfhV4j AZ+z/czbIOxkyplASTPuVnVunGwr1PaxJNImrfpyaIk/BXLNUGxAQ2BMN 7X5zr/l8aOmSqz2RT4fFxkloLxhygpZB8yhKEUFsyHfkryjXZQGM+E/Kk 5UpI+YwrTa8gwgHPmvKCT+rAvnlNsP67Acp73yw9wfQRadHYWpv9VNhTK w==; X-CSE-ConnectionGUID: dL7zCwd0Qmu75v9FlsAJ3w== X-CSE-MsgGUID: VhKLgua6RvGsXGHJkSwS6g== X-IronPort-AV: E=Sophos;i="6.15,203,1739854800"; d="scan'208,217";a="10119955" ARC-Seal: i=1; a=rsa-sha256; s=arcselector5401; d=microsoft.com; cv=none; b=Lm9n4twtcb0WKraXf4Vm6Ty0Qxikv26rHSxzK4dd/Og4992iGZw4xxAjc2SUwK6+X2Wtzx/cdXK4wdE1TGW5eV2qH22R9Ib2cOZ7BCA3/ZVIYdCQDlpN4053W7+SzJIq4tPzWzCRdI1KrtdmeOffxKaLyxwiFU43f9AqEFGSLiYykiRk9pMto+iR92LI4395asJNmCsOO7Rdou7iss8N7VE7zuy4tXmOCz3uzLHodSbLSKvItcDc6spg12njZ4wpm+tKXQnmbMVkOxdRX8U0z0sgDuuUhMmVK0uIFhFST6aLXsdtDHfvHdrd7GRINs+gqnyJnhhG1zzRP4iiMzqdDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector5401; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ehq5aWh+UwJfirBIAPLWq11kpuhC6vVj54y+AW3cqQM=; b=WKKXJHQ0OSBVmn6IOR6yux+twV739RuRsr8+8/bYCVKkovoy5EpqsR5Y2nvVo7XAQpobIiW1U3b9VfUKoddqtUKxrtMCE8bWhDPw8j0ezWxyJgiPwzRf4y4wAFNXdCtccxOd+MlZezcqUphkqZhpts5Cu3C/yqYzwRxJkaW2i4zu15TtTD3tnYqlLiGL94U1vc0gfAYQ0HAyglK58N1oK5BVuBtYwSVPYVYHMy8VC0ZMpWiLBbdd6kOuqirIZdifO6bPxwNKTZVvf0WNMjAgSbM5xytGVltG7/rbH6AoMEH/8ICSyRVfUp+WdL91l5YNvyyeHvToaTjNPAc6aYh66Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=gd-ms.com; dmarc=pass action=none header.from=gd-ms.com; dkim=pass header.d=gd-ms.com; arc=none To: "ltp@lists.linux.it" Thread-Topic: Bug: ROD_SILENT does not preserve its argument list Thread-Index: AduqXLatYYKK666VQemanz5d0/l82A== Date: Thu, 10 Apr 2025 21:22:11 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=gd-ms.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN1P110MB0674:EE_|BN0P110MB1787:EE_ x-ms-office365-filtering-correlation-id: 0e8bb198-b72d-4179-0748-08dd7875c1c3 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; ARA:13230040|366016|1800799024|38070700018|8096899003; x-microsoft-antispam-message-info: =?iso-8859-1?q?tk+2FPXHraTY4TZbRN6xRDhZOa?= =?iso-8859-1?q?719pXqF4eKFNZaxqctD0fdfEf+ktiZ3Zli4gRRKzhImbk+LZN81NgDSJl/iZ?= =?iso-8859-1?q?RU47VTDjp9I1ac+nKTscCK6OyCSU0sKSgwndqraMgZSSgPplObGQhdSHVU+w?= =?iso-8859-1?q?rCBzMwPaJI0m7n6vtji/tX58R0cxEu2903CztirwIEzP+v55sbHH8boVFVjV?= =?iso-8859-1?q?xATAOJpni4SVUUpCHciMa6mFnFpOxl0lBL/tZ38zhgxqB4FPYWDvqHbbX29K?= =?iso-8859-1?q?yk1EjtYMCd2PXSX9vibBmBLnL3tmFDSUg60fB0NBrW6JtKGQA86nLOQRowz3?= =?iso-8859-1?q?GILpUKS4qCorJQ6NJEvWQ2jL4FyM8ep5/agZXPfKXbACyw9cbVjsMuYlSPFC?= =?iso-8859-1?q?FNbSCxPZX/XHItUOcv9wiX8X3IclxnkIkOFh+PrDZLLdLGbNBPtzEpYJCBZS?= =?iso-8859-1?q?i2ZAb/nVFqxm6WuczP2vOJ5QGG9bESMGOdjK104m6rIUiI5qWwm+4eq3PN5e?= =?iso-8859-1?q?K9XyZNr5LD5zVXIHy27e8B4fSPqmATnKM21WTCtFcD0z4pj0vPCl8wl5Ou8F?= =?iso-8859-1?q?qjdCLQJs1cO3LwPEfBk47X5UbMVgTfG8XLJ0Ov61mqtPWX3AVIi3hQi4QbRA?= =?iso-8859-1?q?JFNn/oA27rPA3MaGkGln6cr8BiRMgqYGMbjHqq++73MKqGO/a/g+Y2DBsEh8?= =?iso-8859-1?q?O3SJHwC9TKeXhGxip/1w5rpb+4jepMZ5XeqRavKWHFXucL0MPsGQ2g9/jZ65?= =?iso-8859-1?q?5EZKbCks3fcPUDwQaqDLDIhQtdZKq+dHPi7CuCaUDI/qmpNy26fjXydPsS7+?= =?iso-8859-1?q?WMnfzE1H0yLdkERg972sUpsw5+XXrTN2stccWanfDUpIIvKfP3Sq3XQulnlU?= =?iso-8859-1?q?Ja8Ek/r0a1X8IU/9XN82H1UOSE5Ls1PcHfjpFy2ngiOnv9ElWVL9zGV5ItK3?= =?iso-8859-1?q?S59XEukMXhb+pL8lrJu9uHoxH5tuEQI4VIa761P1BdQkYx2Ojyi1psmKlxvO?= =?iso-8859-1?q?ynykJHLo0eMtbGCrC19+Y7NJ+JtwWVeCALw3r3Yw4QqxpX6ZgXHdUMYbZCuU?= =?iso-8859-1?q?roe7F6BZfvybwptHqWs83wGK4qomlLqKHFWY3RDh3wR8DVtsxK5RGqC0Gcpa?= =?iso-8859-1?q?q8WVI1eDPs0Wv6ys0Gkg6rbouWAHBgHDpsBDXqzaPeSd7u35rVnYtadeTRy0?= =?iso-8859-1?q?yimfQatzCAn2zDkpWyP96UgHxcee+dpCfucvI1Uv5A5Zxl9BRoEUV5LGtx7k?= =?iso-8859-1?q?MMZufCfPXcF6t3Xa/SmrEAj6U6lfqY6sq98+P3iR/bzkQKt9Vnf1QeZg4qIB?= =?iso-8859-1?q?B+wegmq7rBBcQKCIqQX3bEaFEjvEXBlaw1Gix6Tz7DviSgk6DROYOnRWs9Hw?= =?iso-8859-1?q?TtjUBvnFJC4SlSsCjrUN6Kl69CaDR5adh5xiti3D7/pp5JTYkW82rsYqRvTH?= =?iso-8859-1?q?gCZBgP0NtSmbRUSFsiYX9RctCG67/+X+q5hG+j/uXMTKkEtWgqo/26j7mZ5N?= =?iso-8859-1?q?0XaW5xv91Gpgw7JXSaJgpCRThAOA=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN1P110MB0674.NAMP110.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(38070700018)(8096899003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?q?P/TwCOJemHyABgQh6LI73wY?= =?iso-8859-1?q?V3MZ/0tNBA99Uu16ht3CVux21ymIlAYqEbuk2956m2axylG5+kRflvJSVIPn?= =?iso-8859-1?q?Rg1FThpWqTPxi31BVMwcJc9u14aQ+9QqPpYlNLmI+gp90AhZbWL7JmAxHPQ9?= =?iso-8859-1?q?rfI3z4jFb/GwFPcBpM9zX7k9v/e/uG0dIiRWxf54HwC3Eiu77+VSd9aeVBCS?= =?iso-8859-1?q?nHhxaZOaXOXVQgml7tNEZhXrvJRNKF60K6bz46ICcaaigDIFZvqh6uhFQH47?= =?iso-8859-1?q?rawu2lmtcfiqgW1m9B7YPZpIExyYQDdvlTfbs65Fmis1WctRCJAvXJt3dzbr?= =?iso-8859-1?q?sG4Rm4zBj4Oo3CDyGBTuPl2kkGYkfZv+eWw0CIpijFUSUc9Ln6InQ7vkZ629?= =?iso-8859-1?q?i9kBqvxApI4mBZRY/AmX5ypcEtbWnLfDFqMrhPddZLkkTwzWWpz1djtSsJwj?= =?iso-8859-1?q?ajFV1Ng+ApFva3qiP/wFZ1ocCMUZhPAii3dQgpl0/kYD2MxX2q8xDaUdFfVY?= =?iso-8859-1?q?sJAVOf0ImUxAUxcDSKEHniH7/whGMWMamanX4Rl94QjP3JzN/4xfuTpSAyda?= =?iso-8859-1?q?iaftamvXkAQ9rbp04lDRzE9tKX+9A5xi9oQveMV/seDYLsuv1DNxm2S0YEmH?= =?iso-8859-1?q?g5ggH4x/5enCRqAntGe9w12DgGfTeUb+IVcYDSTgSrQXCF27+aw8QkylI1F2?= =?iso-8859-1?q?KfdUQV6bHmfiNK1jBAsTN/QKXBlzPGEcS9LRrkrT9ecf4OLrySJQHQUJbzBH?= =?iso-8859-1?q?WYngtUQUBcD0Da55U+8IbVkrESGYn502JIdNNOASTzDpj10a0+NlTuKNP6HA?= =?iso-8859-1?q?rAEEPEZdir/u9fUJl74lh21ARuuAF+6z2f+ae7MMlmjHu3JHmogElCqNNSLc?= =?iso-8859-1?q?RhPTA83hBnxivjyTO4OBZ27n3l63FQSnN6q0dFi7asqxx8Kw6636X+jWr6tU?= =?iso-8859-1?q?17fcC9Uen8rrNZQc5Z4nspHCzDr7Teb8SncVnDUk+3Gb0dCh1c1UB39A3oxY?= =?iso-8859-1?q?sJxfYjIMJiflZYmYigx9qLPTHGi3tm/KxjviEpTz66EZjuVSgM6RFRLLfdkr?= =?iso-8859-1?q?VglqJZ48rCp0jASgvQFlXHSNosasjCJ/owdkHsJ2Lg+gIQLT1aTibFgTBlAt?= =?iso-8859-1?q?4ovP0w37hC7rXEtrBQhbbKOrJwtD8tC5V36w2jH7Eou2gLtrjsUSLAmREsjO?= =?iso-8859-1?q?ZnlPqvWCIJVHMnN0gsnSsnNVrXauDfo6pjPr4LMjHbJKNWrxgb/BFOQCfCJy?= =?iso-8859-1?q?YB7jpAPT3A+Xdr6y3vQYYGsv+Qdj9/8iPBIK1XZXWvWLEVjNJAnFL1HT53Ch?= =?iso-8859-1?q?+3WhEFJPJvJPPg4zq1FNzwgD3iJ1rljbFnvi3IkJQup5iMFBS8/EuNheNF3T?= =?iso-8859-1?q?RGA9tbj5TSwOE9TIUFFe1PU3Rc9q7lAi/MhnUS/lmKF/RrXBSUx/l7qASIIF?= =?iso-8859-1?q?6zliXTv4m1hshsKIGZi8FdN/ZWsn5Co4n69KVZmIjPPGgezVhjxFpYTFMC+B?= =?iso-8859-1?q?PaxsLhIZmSam8/fiVqmegRdbng1m8V1tOtLjv2CBPhq8DFc+vL70=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN1P110MB0674.NAMP110.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 0e8bb198-b72d-4179-0748-08dd7875c1c3 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Apr 2025 21:22:11.3553 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 7c5a26cf-ddf0-400c-9703-4070b4e3a54d X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0P110MB1787 X-OriginatorOrg: gd-ms.com X-Content-Scanned: Fidelis Mail X-Spam-Status: No, score=0.1 required=7.0 tests=ARC_SIGNED,ARC_VALID, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=disabled version=4.0.0 X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on in-6.smtp.seeweb.it X-Virus-Scanned: clamav-milter 1.0.3 at in-6.smtp.seeweb.it X-Virus-Status: Clean X-Mailman-Approved-At: Fri, 11 Apr 2025 09:24:58 +0200 X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: [LTP] Bug: ROD_SILENT does not preserve its argument list X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: "John.Morin--- via ltp" From: "sowmya.indranna--- via ltp" Reply-To: "John.Morin@gd-ms.com" Errors-To: ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it Sender: "ltp" Hello: Submitting bug against ROD_SILENT. Sincerely, * John Morin. ==== Bug in ROD_SILENT ==== Need to quote "$@" in ROD_SILENT so each parameter is individually quoted. Otherwise, the original structure of its arguments is lost. ==== Fix ==== ==== Test showing bug ==== Test "test1" is an LTP tests. The runs the same command using ROD and ROD_SILENT. The command it runs simply greps for string "blah1 blah2" in file data2. When run, ROD passes while ROD_SILENT fails. This is because ROD_SILENT does not preserve quoted arguments. % cat data2 --- blah1 blah2 blah3 --- % cat test1 #!/bin/bash TST_TESTFUNC="do_test" do_test() { ROD grep "blah1 blah2" data2 ROD_SILENT grep "blah1 blah2" data2 tst_res TPASS "pass" } . tst_test.sh tst_run % ./test1 # Note ROD passes while ROD_SILENT fails > ./test1 test1 1 TINFO: Running: test1 test1 1 TINFO: Tested kernel: ... test1 1 TINFO: timeout per run is 0h 5m 0s --- blah1 blah2 blah3 --- grep: blah2: No such file or directory data2:--- blah1 blah2 blah3 --- test1 1 TBROK: grep blah1 blah2 data2 failed Summary: passed 0 failed 0 broken 1 skipped 0 warnings 0 Signed-off-by: John Morin diff --git a/testcases/lib/tst_test.sh b/testcases/lib/tst_test.sh index 718a6b0ca..cfa327a8a 100644 --- a/testcases/lib/tst_test.sh +++ b/testcases/lib/tst_test.sh @@ -153,7 +153,7 @@ ROD_SILENT() { local tst_out - tst_out="$(tst_rod $@ 2>&1)" + tst_out=$(tst_rod "$@" 2>&1) if [ $? -ne 0 ]; then echo "$tst_out" tst_brk TBROK "$@ failed"