From patchwork Mon Jul 27 09:40:25 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 1336802 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it (client-ip=213.254.12.146; helo=picard.linux.it; envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=Prx7I+Re; dkim-atps=neutral Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4BFZZ16nShz9sPf for ; Mon, 27 Jul 2020 19:41:13 +1000 (AEST) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 293363C27D4 for ; Mon, 27 Jul 2020 11:41:11 +0200 (CEST) X-Original-To: ltp@lists.linux.it Delivered-To: ltp@picard.linux.it Received: from in-7.smtp.seeweb.it (in-7.smtp.seeweb.it [217.194.8.7]) by picard.linux.it (Postfix) with ESMTP id C99353C089D for ; Mon, 27 Jul 2020 11:41:08 +0200 (CEST) Received: from mail-pj1-x1042.google.com (mail-pj1-x1042.google.com [IPv6:2607:f8b0:4864:20::1042]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by in-7.smtp.seeweb.it (Postfix) with ESMTPS id 1E06B2013FB for ; Mon, 27 Jul 2020 11:41:08 +0200 (CEST) Received: by mail-pj1-x1042.google.com with SMTP id i92so1308159pje.0 for ; Mon, 27 Jul 2020 02:41:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=laLhQTYSl9GPgzsivaiG5g++WpbkBq60FGMWRJCpF48=; b=Prx7I+RetKD+CS1ZvWL3geBXrAEcIpDPZFIBs153lDBgqsSTxvKoPlZPnZB9uBuIFC PNtjwUIqdjq8dXhuc5bzBUk+0jG0xHNpKROd6q8qSJ30lObEm1sjv2ZVL8cKpfz0lwrg o8y7NKvXZN4geSWcf8MvlpKw0BgxNLk0B3chjXg6p0vIABV2z6837nD0E/IMcqIFa3Fs 8EiR7T9VVp9JT+QjHM7PdPFfC4xk/7rAiMkpL9/fi3mga3kqjI73PiptcdN557VC5TpQ yEG/Kqf8SSiCSbsFcAhkvoDNoGLeoUdQaZhzKOLz2ELtV+K3MYXStfpmzfbMLDYaPN/+ 4oAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=laLhQTYSl9GPgzsivaiG5g++WpbkBq60FGMWRJCpF48=; b=EAJ0S+g3C4N4HQE1KJnnffaztWIYiC48IC1wsg+QcZHkkB55Z/jVY5AAhap70ZQuh1 R+qfjxW3jzAnWt9aNjPQg4pZ1tyI4/o+ZkEQ7oij5cK0xFprkWsHfbAtSWgGeK8z2ba7 q4OwgqVoCcAmtbyoRJw5Y/4/KIL+GedgAZtKKdew1y4geATAqVdEpnhg3hod7wMj0YFl eYXnZEBdXLnBM0WKUTSKyOry7INYuSKNUKu9BkPRTynCr5Rn5RsCb28bNTGR57Lp+bva hvVTKU5PcFybDqaUcj3kYXiPGflHBDLd/sIg2uiYxRRW4L5ClGXrnEichDtzOGzM/tYN vLqQ== X-Gm-Message-State: AOAM531xoyp+rAMQ8Ya10qkkKkHuTQoAUYCt2a9bbdxd8HWxYFK5tMjW ejCQf2/2AJSh1J1E5aoy9U+IAD05Q8M= X-Google-Smtp-Source: ABdhPJwabHVPaJOordw8QP+jlscdquADY1kCDNE4sKnaStuD6nvntXAQCTDL5YEnMQN4CkAnZbwwKA== X-Received: by 2002:a17:90b:124c:: with SMTP id gx12mr18736799pjb.191.1595842834308; Mon, 27 Jul 2020 02:40:34 -0700 (PDT) Received: from localhost ([223.190.9.130]) by smtp.gmail.com with ESMTPSA id n14sm14596567pgd.78.2020.07.27.02.40.33 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 27 Jul 2020 02:40:33 -0700 (PDT) From: Viresh Kumar To: ltp@lists.linux.it Date: Mon, 27 Jul 2020 15:10:25 +0530 Message-Id: <53c9ed8dc17ea6fa0b46502cd1c724a3a8539c8c.1595842740.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.14.1 MIME-Version: 1.0 X-Virus-Scanned: clamav-milter 0.99.2 at in-7.smtp.seeweb.it X-Virus-Status: Clean X-Spam-Status: No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,SPF_HELO_NONE,SPF_PASS autolearn=disabled version=3.4.0 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on in-7.smtp.seeweb.it Subject: [LTP] [PATCH V2 1/2] libs: sigwait: Fix compilation warning around sigprocmask() X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Viresh Kumar , Vincent Guittot Errors-To: ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it Sender: "ltp" Newer gcc generates following warnings currently: sigwait.c: In function ‘test_masked_matching’: sigwait.c:157:42: warning: passing argument 3 to restrict-qualified parameter aliases with argument 2 [-Wrestrict] 157 | TEST(sigprocmask(SIG_SETMASK, &oldmask, &oldmask)); Fix these by using different pointers for new and old masks. Reported-by: Petr Vorel Signed-off-by: Viresh Kumar --- V2: New patch libs/libltpsigwait/sigwait.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/libs/libltpsigwait/sigwait.c b/libs/libltpsigwait/sigwait.c index dbd33a61f2b1..0a34e6cc3deb 100644 --- a/libs/libltpsigwait/sigwait.c +++ b/libs/libltpsigwait/sigwait.c @@ -156,11 +156,11 @@ void test_masked_matching(swi_func sigwaitinfo, int signo, && si.si_code == SI_USER && si.si_signo == signo, "Struct siginfo mismatch"); - TEST(sigprocmask(SIG_SETMASK, &oldmask, &oldmask)); + TEST(sigprocmask(SIG_SETMASK, &sigs, &oldmask)); if (TST_RET == -1) tst_brk(TBROK | TTERRNO, "restoring original signal mask failed"); - if (sigismember(&oldmask, signo)) + if (sigismember(&sigs, signo)) tst_res(TPASS, "sigwaitinfo restored the original mask"); else tst_res(TFAIL, @@ -214,11 +214,11 @@ void test_masked_matching_rt(swi_func sigwaitinfo, int signo, && si.si_signo == signo + 1, "Struct siginfo mismatch"); - TEST(sigprocmask(SIG_SETMASK, &oldmask, &oldmask)); + TEST(sigprocmask(SIG_SETMASK, &sigs, &oldmask)); if (TST_RET == -1) tst_brk(TBROK | TTERRNO, "restoring original signal mask failed"); - if (sigismember(&oldmask, signo)) + if (sigismember(&sigs, signo)) tst_res(TPASS, "sigwaitinfo restored the original mask"); else tst_res(TFAIL, @@ -250,11 +250,11 @@ void test_masked_matching_noinfo(swi_func sigwaitinfo, int signo, TEST(sigwaitinfo(&sigs, NULL, NULL)); REPORT_SUCCESS(signo, 0); - TEST(sigprocmask(SIG_SETMASK, &oldmask, &oldmask)); + TEST(sigprocmask(SIG_SETMASK, &sigs, &oldmask)); if (TST_RET == -1) tst_brk(TBROK | TTERRNO, "restoring original signal mask failed"); - if (sigismember(&oldmask, signo)) + if (sigismember(&sigs, signo)) tst_res(TPASS, "sigwaitinfo restored the original mask"); else tst_res(TFAIL, @@ -289,7 +289,7 @@ void test_bad_address(swi_func sigwaitinfo, int signo, TEST(sigwaitinfo(&sigs, (void *)1, NULL)); REPORT_SUCCESS(-1, EFAULT); - TEST(sigprocmask(SIG_SETMASK, &oldmask, &oldmask)); + TEST(sigprocmask(SIG_SETMASK, &sigs, &oldmask)); if (TST_RET == -1) tst_brk(TBROK | TTERRNO, "sigprocmask() failed");