diff mbox series

[2/4] syscalls/preadv203: don't treat short write() as failure

Message ID 4a26cbb687ab570411d12ec7c4cd313db47f919f.1664979933.git.jstancek@redhat.com
State Accepted, archived
Headers show
Series [1/4] mmapstress04: use SAFE_WRITE_RETRY from LTP library | expand

Commit Message

Jan Stancek Oct. 5, 2022, 2:25 p.m. UTC 
Test is sporadically running into TBROK in setup() due to short write:
  tst_test.c:1064: TINFO: Formatting /dev/loop0 with xfs opts='' extra opts=''
  preadv203.c:257: TBROK: write(501,0x3fff4ef7d15,4123) failed: SUCCESS (0)

Switch to SAFE_WRITE_RETRY.

Signed-off-by: Jan Stancek <jstancek@redhat.com>
---
 testcases/kernel/syscalls/preadv2/preadv203.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Cyril Hrubis Oct. 5, 2022, 3:51 p.m. UTC | #1 
Hi!
Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
diff mbox series

Patch

diff --git a/testcases/kernel/syscalls/preadv2/preadv203.c b/testcases/kernel/syscalls/preadv2/preadv203.c
index 60dc4a882f16..25c6e1c2ecd0 100644
--- a/testcases/kernel/syscalls/preadv2/preadv203.c
+++ b/testcases/kernel/syscalls/preadv2/preadv203.c
@@ -254,7 +254,7 @@  static void setup(void)
 
 		for (j = 0; j < CHUNKS; j++) {
 			memset(buf, '0' + j, sizeof(buf));
-			SAFE_WRITE(1, fds[i], buf, sizeof(buf));
+			SAFE_WRITE(SAFE_WRITE_RETRY, fds[i], buf, sizeof(buf));
 		}
 	}
 }