| Message ID | 2873e7f25ac44d2c103a030bfc5f1d30e0fe80a9.1655795105.git.jstancek@redhat.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | syscalls/migrate_pages03: restore runtime to 5m | expand |
Hi! > Arches with large pages have trouble completing all loops in 30s, > restore runtime to 5m. Can we please also exit the test when it's out of runtime? The whole point of runtime is that test inner loop actively checks for remaining runtime so that the runtime is capped. Should be as easy as: diff --git a/testcases/kernel/syscalls/migrate_pages/migrate_pages03.c b/testcases/kernel/syscalls/migrate_pages/migrate_pages03.c index c6afb4cce..2866c96e6 100644 --- a/testcases/kernel/syscalls/migrate_pages/migrate_pages03.c +++ b/testcases/kernel/syscalls/migrate_pages/migrate_pages03.c @@ -127,6 +127,11 @@ static void migrate_test(void) tst_res(TFAIL | TERRNO, "migrate_pages() failed"); return; } + + if (!tst_remaining_runtime()) { + tst_res(TINFO, "Out of runtime, exitting..."); + break; + } } SAFE_SETEUID(0); @@ -134,6 +139,7 @@ static void migrate_test(void) } static struct tst_test test = { + .max_runtime = 300, .min_kver = "2.6.32", .needs_root = 1, .setup = setup,
diff --git a/testcases/kernel/syscalls/migrate_pages/migrate_pages03.c b/testcases/kernel/syscalls/migrate_pages/migrate_pages03.c index c6afb4cce05d..ce1aa5be421d 100644 --- a/testcases/kernel/syscalls/migrate_pages/migrate_pages03.c +++ b/testcases/kernel/syscalls/migrate_pages/migrate_pages03.c @@ -134,6 +134,7 @@ static void migrate_test(void) } static struct tst_test test = { + .max_runtime = 300, .min_kver = "2.6.32", .needs_root = 1, .setup = setup,
Arches with large pages have trouble completing all loops in 30s, restore runtime to 5m. Signed-off-by: Jan Stancek <jstancek@redhat.com> --- testcases/kernel/syscalls/migrate_pages/migrate_pages03.c | 1 + 1 file changed, 1 insertion(+)