diff mbox series

[v2] syscalls/msgstress01: Set upper bound for num_messages

Message ID 20250512-fixes-msgstress01-v2-1-49df739d93ca@suse.com
State Accepted
Headers show
Series [v2] syscalls/msgstress01: Set upper bound for num_messages | expand

Checks

Context Check Description
ltpci/debian_stable_aarch64-linux-gnu-gcc_arm64 success success
ltpci/debian_stable_s390x-linux-gnu-gcc_s390x success success
ltpci/debian_stable_gcc success success
ltpci/debian_stable_powerpc64le-linux-gnu-gcc_ppc64el success success
ltpci/debian_stable_gcc success success
ltpci/ubuntu_jammy_gcc success success
ltpci/ubuntu_bionic_gcc success success
ltpci/alpine_latest_gcc success success
ltpci/debian_testing_gcc success success
ltpci/opensuse-leap_latest_gcc success success
ltpci/debian_oldstable_clang success success
ltpci/opensuse-archive_42-2_gcc success success
ltpci/quay-io-centos-centos_stream9_gcc success success
ltpci/fedora_latest_clang success success
ltpci/debian_testing_clang success success
ltpci/debian_oldstable_gcc success success

Commit Message

Ricardo B. Marlière May 12, 2025, 12:10 p.m. UTC 
From: Ricardo B. Marlière <rbm@suse.com>

The msgstress01 test has a workaround to limit the amount of processes it
will spawn, but it is only used if the option str_num_messages (-n) is
passed. This is known to be problematic in low memory SUTs, so make sure
it's used.

Suggested-by: Martin Doucha <mdoucha@suse.cz>
Signed-off-by: Ricardo B. Marlière <rbm@suse.com>
---
Changes in v2:
- Print a message if num_messages value is reduced
- Link to v1: https://lore.kernel.org/r/20250512-fixes-msgstress01-v1-1-d335f7c131c0@suse.com
---
 testcases/kernel/syscalls/ipc/msgstress/msgstress01.c | 8 ++++++++
 1 file changed, 8 insertions(+)


---
base-commit: 4a0e3a8fa7b592958f8e3cd366f63c78fba9f014
change-id: 20250512-fixes-msgstress01-4157ceb54b38

Best regards,

Comments

Andrea Cervesato May 20, 2025, 1:11 p.m. UTC | #1 
Hi!

On 5/12/25 14:10, Ricardo B. Marlière via ltp wrote:
> +	if (num_messages > avail_msg) {
> +		if (avail_msg < num_messages / 2)
> +			tst_res(TWARN, "Number of messages reduced to %d", avail_msg);
> +		else
> +			tst_res(TINFO, "Number of messages reduced to %d", avail_msg);
> +		num_messages = avail_msg;
> +	}

We can simplify with:

     tst_res(
         avail_msg < num_messages / 2 ? TWARN : TINFO,
         "Number of messages reduced to %d", avail_msg);

- Andrea
diff mbox series

Patch

diff --git a/testcases/kernel/syscalls/ipc/msgstress/msgstress01.c b/testcases/kernel/syscalls/ipc/msgstress/msgstress01.c
index ae637e5d7ad89c1257c9cce0145122497c19ee64..5fd4cd430f63de4755b4c1d03bf122fb49ddf0d1 100644
--- a/testcases/kernel/syscalls/ipc/msgstress/msgstress01.c
+++ b/testcases/kernel/syscalls/ipc/msgstress/msgstress01.c
@@ -271,6 +271,14 @@  static void setup(void)
 	if (tst_parse_int(str_num_messages, &num_messages, 1, avail_msg))
 		tst_brk(TBROK, "Invalid number of messages '%s'", str_num_messages);
 
+	if (num_messages > avail_msg) {
+		if (avail_msg < num_messages / 2)
+			tst_res(TWARN, "Number of messages reduced to %d", avail_msg);
+		else
+			tst_res(TINFO, "Number of messages reduced to %d", avail_msg);
+		num_messages = avail_msg;
+	}
+
 	if (tst_parse_int(str_num_iterations, &num_iterations, 1, MAXNREPS))
 		tst_brk(TBROK, "Invalid number of messages iterations '%s'", str_num_iterations);