diff mbox series

[v4,1/8] syscalls/mknod01: Fix checkpatch.pl warnings

Message ID 20250425-conversions-mknod-v4-1-222e0d2e7ef1@suse.com
State Needs Review / ACK
Headers show
Series syscalls/mknod: Refactor all tests | expand

Checks

Context Check Description
ltpci/debian_stable_s390x-linux-gnu-gcc_s390x success success
ltpci/debian_stable_powerpc64le-linux-gnu-gcc_ppc64el success success
ltpci/debian_stable_aarch64-linux-gnu-gcc_arm64 success success
ltpci/debian_stable_gcc success success
ltpci/ubuntu_jammy_gcc success success
ltpci/debian_stable_gcc success success
ltpci/quay-io-centos-centos_stream9_gcc success success
ltpci/debian_oldstable_clang success success
ltpci/opensuse-leap_latest_gcc success success
ltpci/debian_oldstable_gcc success success
ltpci/fedora_latest_clang success success
ltpci/debian_testing_gcc success success
ltpci/ubuntu_bionic_gcc success success
ltpci/alpine_latest_gcc success success
ltpci/opensuse-archive_42-2_gcc success success
ltpci/debian_testing_clang success success

Commit Message

Ricardo B. Marlière April 25, 2025, 6:06 p.m. UTC 
From: Ricardo B. Marlière <rbm@suse.com>

Fix the following warnings:

	Alignment should match open parenthesis
	Please don't use multiple blank lines

Also, fix 32b compat mode warning:

mknod01.c:37:22: warning: format ‘%ld’ expects argument of type ‘long int’,
but argument 6 has type ‘dev_t’

Signed-off-by: Ricardo B. Marlière <rbm@suse.com>
---
 testcases/kernel/syscalls/mknod/mknod01.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
diff mbox series

Patch

diff --git a/testcases/kernel/syscalls/mknod/mknod01.c b/testcases/kernel/syscalls/mknod/mknod01.c
index fe0a1cfa6a473f9c2b2a55493f830f13b86560a8..0f0c17a5fd157e58359a586be2e268e42fa0eb0b 100644
--- a/testcases/kernel/syscalls/mknod/mknod01.c
+++ b/testcases/kernel/syscalls/mknod/mknod01.c
@@ -10,6 +10,8 @@ 
  * various modes.
  */
 
+#include <inttypes.h>
+#include <stdint.h>
 #include <sys/sysmacros.h>
 #include "tst_test.h"
 
@@ -26,7 +28,6 @@  static int tcases[] = {
 	S_IFREG | 06700,
 };
 
-
 static void run(unsigned int i)
 {
 	dev_t dev = 0;
@@ -35,8 +36,8 @@  static void run(unsigned int i)
 		dev = makedev(1, 3);
 
 	TST_EXP_PASS(mknod(PATH, tcases[i], dev),
-				"mknod(PATH, %o, %ld)",
-				tcases[i], dev);
+		     "mknod(PATH, %o, %" PRIuMAX ")",
+		     tcases[i], (uintmax_t)dev);
 	SAFE_UNLINK(PATH);
 }