diff mbox series

[v3,1/2] openposix: Makefile: Add the standard "maintainer-clean" target

Message ID 20250409-fix_make_clean-v3-1-a33a84b2be05@suse.com
State Accepted
Headers show
Series configure: Tidy up removal of generated artifacts | expand

Checks

Context Check Description
acer/ubuntu_bionic_gcc fail failure
acer/debian_stable_s390x-linux-gnu-gcc_s390x success success
acer/debian_stable_aarch64-linux-gnu-gcc_arm64 success success
acer/debian_stable_powerpc64le-linux-gnu-gcc_ppc64el success success
acer/ubuntu_jammy_gcc success success
acer/debian_stable_gcc success success
acer/alpine_latest_gcc success success
acer/debian_stable_gcc success success
acer/fedora_latest_clang success success
acer/debian_testing_clang success success
acer/debian_testing_gcc success success
acer/debian_oldstable_gcc success success
acer/debian_oldstable_clang success success
acer/opensuse_leap_latest_gcc success success

Commit Message

Ricardo B. Marlière April 9, 2025, 4:36 p.m. UTC 
From: Ricardo B. Marlière <rbm@suse.com>

The include/mk/automake.mk file define the standard "maintainer-clean" and
"ac-maintainer-clean" targets and therein it calls the same targets under
each AUTOCONFED_SUBDIRS, but in the case of the openposix test suite, they
don't exist. Add them and also remove some dangling files in ac-clean.

This fixes the following error when calling `make maintainer-clean` from
the project's top level directory:

make[1]: Entering directory './testcases/open_posix_testsuite'
make[1]: *** No rule to make target 'ac-maintainer-clean'.  Stop.
make[1]: Leaving directory './testcases/open_posix_testsuite'
make: *** [./include/mk/automake.mk:68: ac-maintainer-clean] Error 2

Reviewed-by: Petr Vorel <pvorel@suse.cz>
Signed-off-by: Ricardo B. Marlière <rbm@suse.com>
---
 testcases/open_posix_testsuite/Makefile | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

Comments

Petr Vorel April 23, 2025, 7:14 a.m. UTC | #1 
Hi Ricardo,

patch merged. Thank you!

Kind regards,
Petr
diff mbox series

Patch

diff --git a/testcases/open_posix_testsuite/Makefile b/testcases/open_posix_testsuite/Makefile
index 8b4c8c0a24b833fa0fb21ce3e253629f358f1800..c0ccd499b8b9c93e45133f5b3f189eda7d09beb3 100644
--- a/testcases/open_posix_testsuite/Makefile
+++ b/testcases/open_posix_testsuite/Makefile
@@ -31,11 +31,16 @@  AUTOGENERATED_FILES = include/mk/config.mk
 
 .PHONY: ac-clean
 ac-clean: clean
+	$(RM) -rf autom4te.cache
+	$(RM) -f config.log config.status
+
+.PHONE: ac-maintainer-clean
+ac-maintainer-clean:
+	$(RM) -f configure
 
 .PHONY: clean
 clean:
 	$(RM) -f $(LOGFILE)*
-	$(RM) -f config.log config.status
 	@for dir in $(SUBDIRS) tools; do \
 		$(MAKE) -C $$dir clean >/dev/null; \
 	done
@@ -51,6 +56,9 @@  distclean-makefiles:
 		$(MAKE) -C $$dir $@; \
 	done
 
+.PHONY: maintainer-clean
+maintainer-clean: distclean-makefiles ac-maintainer-clean
+
 $(AUTOGENERATED_FILES): $(top_builddir)/config.status
 	$(SHELL) $^