diff mbox series

tst_fd: Use raw syscall for fanotify_init

Message ID 20240223000543.1135129-1-edliaw@google.com
State Accepted
Headers show
Series tst_fd: Use raw syscall for fanotify_init | expand

Commit Message

Edward Liaw Feb. 23, 2024, 12:05 a.m. UTC
Some systems do not provide sys/fanotify.h, such as Android.  We can use
the raw syscall for open_fanotify to avoid importing the header file.

Suggested-by: Cyril Hrubis <chrubis@suse.cz>
Signed-off-by: Edward Liaw <edliaw@google.com>
---
 lib/tst_fd.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Li Wang Feb. 23, 2024, 7:02 a.m. UTC | #1
On Fri, Feb 23, 2024 at 8:06 AM Edward Liaw via ltp <ltp@lists.linux.it>
wrote:

> Some systems do not provide sys/fanotify.h, such as Android.  We can use
> the raw syscall for open_fanotify to avoid importing the header file.
>
> Suggested-by: Cyril Hrubis <chrubis@suse.cz>
> Signed-off-by: Edward Liaw <edliaw@google.com>
>

Reviewed-by: Li Wang <liwang@redhat.com>
Petr Vorel Feb. 23, 2024, 8:40 a.m. UTC | #2
Hi all,

thanks, merged!

Kind regards,
Petr
diff mbox series

Patch

diff --git a/lib/tst_fd.c b/lib/tst_fd.c
index b3d43a7c3..6538a098c 100644
--- a/lib/tst_fd.c
+++ b/lib/tst_fd.c
@@ -10,9 +10,9 @@ 
 #include <sys/eventfd.h>
 #include <sys/signalfd.h>
 #include <sys/timerfd.h>
-#include <sys/fanotify.h>
 #include <sys/inotify.h>
 #include <linux/perf_event.h>
+#include <linux/fanotify.h>
 
 #include "tst_test.h"
 #include "tst_safe_macros.h"
@@ -146,7 +146,7 @@  static void open_pidfd(struct tst_fd *fd)
 
 static void open_fanotify(struct tst_fd *fd)
 {
-	fd->fd = fanotify_init(FAN_CLASS_NOTIF, O_RDONLY);
+	fd->fd = syscall(__NR_fanotify_init, FAN_CLASS_NOTIF, O_RDONLY);
 	if (fd->fd < 0) {
 		tst_res(TCONF | TERRNO,
 			"Skipping %s", tst_fd_desc(fd));