diff mbox series

[v1] Add stat04 test

Message ID 20240118151547.12980-1-andrea.cervesato@suse.de
State Superseded
Headers show
Series [v1] Add stat04 test | expand

Commit Message

Andrea Cervesato Jan. 18, 2024, 3:15 p.m. UTC 
From: Andrea Cervesato <andrea.cervesato@suse.com>

This test has been extracted from symlink01 test and it tests stat()
functionalities on symlink generated file.

Signed-off-by: Andrea Cervesato <andrea.cervesato@suse.com>
---
 runtest/smoketest                         |  2 +-
 runtest/syscalls                          |  4 +-
 testcases/kernel/syscalls/stat/.gitignore |  2 +
 testcases/kernel/syscalls/stat/stat04.c   | 75 +++++++++++++++++++++++
 4 files changed, 80 insertions(+), 3 deletions(-)
 create mode 100644 testcases/kernel/syscalls/stat/stat04.c

Comments

Cyril Hrubis Feb. 2, 2024, 4:48 p.m. UTC | #1 
Hi!
> +#include "tst_test.h"
> +
> +static void test_stat(void)
> +{
> +	char *symname = "my_symlink0";
> +
> +	TST_EXP_PASS(symlink(tst_get_tmpdir(), symname));

This one leaks memory from the tst_get_tmpdir() call, also I suppose
that the symlink can be created once in the test setup and removed once
in the test cleanup.

> +	struct stat path_stat;
> +	struct stat link_stat;
> +
> +	SAFE_STAT(tst_get_tmpdir(), &path_stat);

Here as well, leak. I suppose that we can instead use "."

> +	SAFE_STAT(symname, &link_stat);
> +
> +	TST_EXP_EQ_LI(path_stat.st_dev, link_stat.st_dev);
> +	TST_EXP_EQ_LI(path_stat.st_mode, link_stat.st_mode);
> +	TST_EXP_EQ_LI(path_stat.st_nlink, link_stat.st_nlink);
> +	TST_EXP_EQ_LI(path_stat.st_uid, link_stat.st_uid);
> +	TST_EXP_EQ_LI(path_stat.st_gid, link_stat.st_gid);
> +	TST_EXP_EQ_LI(path_stat.st_size, link_stat.st_size);
> +	TST_EXP_EQ_LI(path_stat.st_atime, link_stat.st_atime);
> +	TST_EXP_EQ_LI(path_stat.st_mtime, link_stat.st_mtime);
> +	TST_EXP_EQ_LI(path_stat.st_ctime, link_stat.st_ctime);
> +
> +	SAFE_UNLINK(symname);
> +}
> +
> +static void test_stat_no_path(void)
> +{
> +	char *symname = "my_symlink1";
> +	struct stat link_stat;
> +
> +	TST_EXP_PASS(symlink("bc+eFhi!k", symname));
> +	TST_EXP_FAIL(stat(symname, &link_stat), ENOENT);
> +
> +	SAFE_UNLINK(symname);
> +}

This one should rather go into stat03.c

> +static void test_stat_loop(void)
> +{
> +	char *symname = "my_symlink2";
> +	struct stat link_stat;
> +
> +	TST_EXP_PASS(symlink(symname, symname));
> +	TST_EXP_FAIL(stat(symname, &link_stat), ELOOP);
> +
> +	SAFE_UNLINK(symname);
> +}

This one is already tested in stat03.c

> +static void run(void)
> +{
> +	test_stat();
> +	test_stat_no_path();
> +	test_stat_loop();
> +}
> +
> +static struct tst_test test = {
> +	.test_all = run,
> +	.needs_tmpdir = 1,
> +};
> -- 
> 2.35.3
> 
> 
> -- 
> Mailing list info: https://lists.linux.it/listinfo/ltp
diff mbox series

Patch

diff --git a/runtest/smoketest b/runtest/smoketest
index 83eebfe7b..5608417f9 100644
--- a/runtest/smoketest
+++ b/runtest/smoketest
@@ -8,7 +8,7 @@  time01 time01
 wait02 wait02
 write01 write01
 symlink01 symlink01
-stat04 symlink01 -T stat04
+stat04 stat04
 utime01A symlink01 -T utime01
 rename01A symlink01 -T rename01
 splice02 splice02 -s 20
diff --git a/runtest/syscalls b/runtest/syscalls
index 6e2407879..8dd8a49ca 100644
--- a/runtest/syscalls
+++ b/runtest/syscalls
@@ -1529,8 +1529,8 @@  stat02 stat02
 stat02_64 stat02_64
 stat03 stat03
 stat03_64 stat03_64
-stat04 symlink01 -T stat04
-stat04_64 symlink01 -T stat04_64
+stat04 stat04
+stat04_64 stat04_64
 
 statfs01 statfs01
 statfs01_64 statfs01_64
diff --git a/testcases/kernel/syscalls/stat/.gitignore b/testcases/kernel/syscalls/stat/.gitignore
index fa0a4ce9f..0a62dc6ee 100644
--- a/testcases/kernel/syscalls/stat/.gitignore
+++ b/testcases/kernel/syscalls/stat/.gitignore
@@ -4,3 +4,5 @@ 
 /stat02_64
 /stat03
 /stat03_64
+/stat04
+/stat04_64
diff --git a/testcases/kernel/syscalls/stat/stat04.c b/testcases/kernel/syscalls/stat/stat04.c
new file mode 100644
index 000000000..879eec996
--- /dev/null
+++ b/testcases/kernel/syscalls/stat/stat04.c
@@ -0,0 +1,75 @@ 
+// SPDX-License-Identifier: GPL-2.0-or-later
+/*
+ * Copyright (c) 2000 Silicon Graphics, Inc.  All Rights Reserved.
+ *    Author: David Fenner
+ *    Copilot: Jon Hendrickson
+ * Copyright (C) 2024 Andrea Cervesato <andrea.cervesato@suse.com>
+ */
+
+/*\
+ * [Description]
+ *
+ * This test verifies that stat() is working correctly on symlink()
+ * generated files.
+ */
+
+#include "tst_test.h"
+
+static void test_stat(void)
+{
+	char *symname = "my_symlink0";
+
+	TST_EXP_PASS(symlink(tst_get_tmpdir(), symname));
+
+	struct stat path_stat;
+	struct stat link_stat;
+
+	SAFE_STAT(tst_get_tmpdir(), &path_stat);
+	SAFE_STAT(symname, &link_stat);
+
+	TST_EXP_EQ_LI(path_stat.st_dev, link_stat.st_dev);
+	TST_EXP_EQ_LI(path_stat.st_mode, link_stat.st_mode);
+	TST_EXP_EQ_LI(path_stat.st_nlink, link_stat.st_nlink);
+	TST_EXP_EQ_LI(path_stat.st_uid, link_stat.st_uid);
+	TST_EXP_EQ_LI(path_stat.st_gid, link_stat.st_gid);
+	TST_EXP_EQ_LI(path_stat.st_size, link_stat.st_size);
+	TST_EXP_EQ_LI(path_stat.st_atime, link_stat.st_atime);
+	TST_EXP_EQ_LI(path_stat.st_mtime, link_stat.st_mtime);
+	TST_EXP_EQ_LI(path_stat.st_ctime, link_stat.st_ctime);
+
+	SAFE_UNLINK(symname);
+}
+
+static void test_stat_no_path(void)
+{
+	char *symname = "my_symlink1";
+	struct stat link_stat;
+
+	TST_EXP_PASS(symlink("bc+eFhi!k", symname));
+	TST_EXP_FAIL(stat(symname, &link_stat), ENOENT);
+
+	SAFE_UNLINK(symname);
+}
+
+static void test_stat_loop(void)
+{
+	char *symname = "my_symlink2";
+	struct stat link_stat;
+
+	TST_EXP_PASS(symlink(symname, symname));
+	TST_EXP_FAIL(stat(symname, &link_stat), ELOOP);
+
+	SAFE_UNLINK(symname);
+}
+
+static void run(void)
+{
+	test_stat();
+	test_stat_no_path();
+	test_stat_loop();
+}
+
+static struct tst_test test = {
+	.test_all = run,
+	.needs_tmpdir = 1,
+};