| Message ID | 20240104204614.1426027-6-pvorel@suse.cz |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | metadata: improvements | expand |
Hi! If we just use the V=1 variable directly I we shouldn't need to pass the VERBOSE= variable here, or do I miss something?
Hi Cyril, > Hi! > If we just use the V=1 variable directly I we shouldn't need to pass the > VERBOSE= variable here, or do I miss something? As I noted elsewhere we support both VERBOSE=1 and V=1. We can decide to switch to only V=1 if you want (in make build in include/mk/env_pre.mk). Kind regards, Petr
diff --git a/metadata/Makefile b/metadata/Makefile index 522af4270..750804175 100644 --- a/metadata/Makefile +++ b/metadata/Makefile @@ -13,7 +13,7 @@ INSTALL_DIR = metadata .PHONY: ltp.json ltp.json: metaparse - $(abs_srcdir)/parse.sh > ltp.json + VERBOSE=$(VERBOSE) $(abs_srcdir)/parse.sh > ltp.json ifeq ($(WITH_METADATA),yes) mkdir -p $(abs_top_builddir)/docparse $(MAKE) -C $(abs_top_builddir)/docparse/ -f $(abs_top_srcdir)/docparse/Makefile @@ -25,6 +25,6 @@ install: endif test: - $(MAKE) -C $(abs_srcdir)/tests/ test + $(MAKE) -C $(abs_srcdir)/tests/ VERBOSE=$(VERBOSE) test include $(top_srcdir)/include/mk/generic_leaf_target.mk
Pass VERBOSE variable to: * parse.sh (=> pass -v to metaparse.c if VERBOSE=1) * make test target (=> pass VERBOSE variable to test.sh) Signed-off-by: Petr Vorel <pvorel@suse.cz> --- metadata/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)