| Message ID | 20230926124647.152972-3-pvorel@suse.cz |
|---|---|
| State | Accepted |
| Headers | show |
| Series | Fix vma05.sh on $DEBUGINFOD_URLS | expand |
Hi! > Maybe this sanity check is useless. WDYT? I guess that it does not harm. > testcases/kernel/mem/vma/vma05.sh | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/testcases/kernel/mem/vma/vma05.sh b/testcases/kernel/mem/vma/vma05.sh > index c9e4becdb..30b1d689a 100755 > --- a/testcases/kernel/mem/vma/vma05.sh > +++ b/testcases/kernel/mem/vma/vma05.sh > @@ -54,6 +54,8 @@ vma_report_check() > > rm -rf core* > { vma05_vdso; } > /dev/null 2>&1 > + [ -f core ] || tst_brk TCONF "missing core file" TCONF or TBROK that is the question.
> Hi! > > Maybe this sanity check is useless. WDYT? > I guess that it does not harm. Thanks for your review! > > testcases/kernel/mem/vma/vma05.sh | 2 ++ > > 1 file changed, 2 insertions(+) > > diff --git a/testcases/kernel/mem/vma/vma05.sh b/testcases/kernel/mem/vma/vma05.sh > > index c9e4becdb..30b1d689a 100755 > > --- a/testcases/kernel/mem/vma/vma05.sh > > +++ b/testcases/kernel/mem/vma/vma05.sh > > @@ -54,6 +54,8 @@ vma_report_check() > > rm -rf core* > > { vma05_vdso; } > /dev/null 2>&1 > > + [ -f core ] || tst_brk TCONF "missing core file" > TCONF or TBROK that is the question. I guess TBROK is better in this case. I wonder myself why I type TCONF. If nobody complains, I'll merge this with TBROK and your ack. Kind regards, Petr
Hi all, > > Hi! > > > Maybe this sanity check is useless. WDYT? > > I guess that it does not harm. > Thanks for your review! > > > testcases/kernel/mem/vma/vma05.sh | 2 ++ > > > 1 file changed, 2 insertions(+) > > > diff --git a/testcases/kernel/mem/vma/vma05.sh b/testcases/kernel/mem/vma/vma05.sh > > > index c9e4becdb..30b1d689a 100755 > > > --- a/testcases/kernel/mem/vma/vma05.sh > > > +++ b/testcases/kernel/mem/vma/vma05.sh > > > @@ -54,6 +54,8 @@ vma_report_check() > > > rm -rf core* > > > { vma05_vdso; } > /dev/null 2>&1 > > > + [ -f core ] || tst_brk TCONF "missing core file" > > TCONF or TBROK that is the question. > I guess TBROK is better in this case. I wonder myself why I type TCONF. > If nobody complains, I'll merge this with TBROK and your ack. Merged with TBROK, thanks for your time. Kind regards, Petr > Kind regards, > Petr
diff --git a/testcases/kernel/mem/vma/vma05.sh b/testcases/kernel/mem/vma/vma05.sh index c9e4becdb..30b1d689a 100755 --- a/testcases/kernel/mem/vma/vma05.sh +++ b/testcases/kernel/mem/vma/vma05.sh @@ -54,6 +54,8 @@ vma_report_check() rm -rf core* { vma05_vdso; } > /dev/null 2>&1 + [ -f core ] || tst_brk TCONF "missing core file" + TRACE=$(gdb -silent -ex="thread apply all backtrace" -ex="quit"\ vma05_vdso ./core* 2> /dev/null) if echo "$TRACE" | grep -qF "??"; then
Because we redirect gdb output, add sanity check for core file being created. Signed-off-by: Petr Vorel <pvorel@suse.cz> --- Maybe this sanity check is useless. WDYT? Kind regards, Petr testcases/kernel/mem/vma/vma05.sh | 2 ++ 1 file changed, 2 insertions(+)