| Message ID | 20230918102711.9567-1-pvorel@suse.cz |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/1] tst_fill_fs: Fix printf format error | expand |
Hi! > openat() first parameter is file descriptor (int), not string. > Add also original path (string) to be more informative. > > Fixes: df1b01cc1 ("tst_fill_fs: drop safe_macro from fill_flat_vec") > Signed-off-by: Petr Vorel <pvorel@suse.cz> Reviewed-by: Cyril Hrubis <chrubis@suse.cz> > --- > I'd like to get this tiny fix merged before the release. Yes please.
Hi Cyril, > Hi! > > openat() first parameter is file descriptor (int), not string. > > Add also original path (string) to be more informative. > > Fixes: df1b01cc1 ("tst_fill_fs: drop safe_macro from fill_flat_vec") > > Signed-off-by: Petr Vorel <pvorel@suse.cz> > Reviewed-by: Cyril Hrubis <chrubis@suse.cz> > > --- > > I'd like to get this tiny fix merged before the release. > Yes please. Thanks for your review, merged. Kind regards, Petr
diff --git a/lib/tst_fill_fs.c b/lib/tst_fill_fs.c index 243eb279f..5e8cf9197 100644 --- a/lib/tst_fill_fs.c +++ b/lib/tst_fill_fs.c @@ -93,7 +93,8 @@ void fill_flat_vec(const char *path, int verbose) tst_res(TINFO | TERRNO, "openat()"); return; } - tst_brk(TBROK | TERRNO, "openat(%s, %d, 0600) failed", dir, O_PATH | O_DIRECTORY); + tst_brk(TBROK | TERRNO, "openat(%d, %d, 0600) failed for path %s", + dir, O_PATH | O_DIRECTORY, path); } SAFE_CLOSE(dir);
openat() first parameter is file descriptor (int), not string. Add also original path (string) to be more informative. Fixes: df1b01cc1 ("tst_fill_fs: drop safe_macro from fill_flat_vec") Signed-off-by: Petr Vorel <pvorel@suse.cz> --- I'd like to get this tiny fix merged before the release. Kind regards, Petr lib/tst_fill_fs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)