diff mbox series

[v3,1/2] Replace runltp-ng with kirk framework

Message ID 20230918082506.17464-2-andrea.cervesato@suse.de
State Superseded
Headers show
Series Add kirk & ltx tools | expand

Commit Message

Andrea Cervesato Sept. 18, 2023, 8:25 a.m. UTC 
From: Andrea Cervesato <andrea.cervesato@suse.com>

Kirk application is the runltp-ng successor and it aims to merge
multiple Linux testing frameworks in one tool, providing support
for remote testing via Qemu, SSH, LTX, parallel execution and much
more.

This patch deprecates runltp-ng, which is not replaced by kirk. All
runltp-ng features are present in kirk and even more.

Signed-off-by: Andrea Cervesato <andrea.cervesato@suse.com>
---
 .gitmodules | 3 +++
 tools/kirk  | 1 +
 2 files changed, 4 insertions(+)
 create mode 160000 tools/kirk

Comments

Petr Vorel Sept. 18, 2023, 9:01 a.m. UTC | #1 
Hi Andrea,

...
> +++ b/.gitmodules
> @@ -7,3 +7,6 @@
>  [submodule "tools/runltp-ng"]
>  	path = tools/runltp-ng
>  	url = https://github.com/linux-test-project/runltp-ng.git
> +[submodule "tools/kirk"]
> +	path = tools/kirk
> +	url = https://github.com/linux-test-project/kirk.git

I'm not sure if anybody asked you to keep runltp-ng, but I'd prefer to remove
runltp-ng as you did in v2. I don't think runltp-ng was really adopted a lot

We should have runltp-ng symlink to kirk at least in LTP:

cd tools/kirk && make install
install -m 00644 ../../tools/kirk/libkirk/*.py /opt/ltp/libkirk
install -m 00775 ../../tools/kirk/kirk /opt/ltp/kirk
...
Here I would add
ln -s /opt/ltp/kirk /opt/ltp/runltp-ng

...
> +++ b/tools/kirk
> @@ -0,0 +1 @@
> +Subproject commit c7419dd6f73d90f3f02aa17d30270e895e30c88e
+1 for fixing this.

Kind regards,
Petr
Andrea Cervesato Sept. 18, 2023, 9:06 a.m. UTC | #2 
Hi,

On 9/18/23 11:01, Petr Vorel wrote:
> Hi Andrea,
>
> ...
>> +++ b/.gitmodules
>> @@ -7,3 +7,6 @@
>>   [submodule "tools/runltp-ng"]
>>   	path = tools/runltp-ng
>>   	url = https://github.com/linux-test-project/runltp-ng.git
>> +[submodule "tools/kirk"]
>> +	path = tools/kirk
>> +	url = https://github.com/linux-test-project/kirk.git
> I'm not sure if anybody asked you to keep runltp-ng, but I'd prefer to remove
> runltp-ng as you did in v2. I don't think runltp-ng was really adopted a lot
Yes, I forgot to do git rm on that folder.
>
> We should have runltp-ng symlink to kirk at least in LTP:
>
> cd tools/kirk && make install
> install -m 00644 ../../tools/kirk/libkirk/*.py /opt/ltp/libkirk
> install -m 00775 ../../tools/kirk/kirk /opt/ltp/kirk
> ...
> Here I would add
> ln -s /opt/ltp/kirk /opt/ltp/runltp-ng
This has to be done in the kirk repo.
> ...
>> +++ b/tools/kirk
>> @@ -0,0 +1 @@
>> +Subproject commit c7419dd6f73d90f3f02aa17d30270e895e30c88e
> +1 for fixing this.
>
> Kind regards,
> Petr

Andrea
diff mbox series

Patch

diff --git a/.gitmodules b/.gitmodules
index d1d558b9e..c389186c9 100644
--- a/.gitmodules
+++ b/.gitmodules
@@ -7,3 +7,6 @@ 
 [submodule "tools/runltp-ng"]
 	path = tools/runltp-ng
 	url = https://github.com/linux-test-project/runltp-ng.git
+[submodule "tools/kirk"]
+	path = tools/kirk
+	url = https://github.com/linux-test-project/kirk.git
diff --git a/tools/kirk b/tools/kirk
new file mode 160000
index 000000000..c7419dd6f
--- /dev/null
+++ b/tools/kirk
@@ -0,0 +1 @@ 
+Subproject commit c7419dd6f73d90f3f02aa17d30270e895e30c88e