| Message ID | 20230215145440.78482-4-teo.coupriediaz@arm.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | lib/tst_pid: Find session PID limit more reliably | expand |
Hello, Teo Couprie Diaz <teo.coupriediaz@arm.com> writes: > It appears that msgstress03 doesn't account for all PIDs that its children > can use, as it expects the tasks will terminate quickly and not reach > the PID limit. > On some systems, this assumption can be invalid and the PID limit > will be hit. > Change the limit to account for all possible children at once, knowning > that each child will fork as well. Reviewed-by: Richard Palethorpe <rpalethorpe@suse.com> > > Signed-off-by: Teo Couprie Diaz <teo.coupriediaz@arm.com> > --- > testcases/kernel/syscalls/ipc/msgstress/msgstress03.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/testcases/kernel/syscalls/ipc/msgstress/msgstress03.c b/testcases/kernel/syscalls/ipc/msgstress/msgstress03.c > index 3cb70ab18..0c46927b8 100644 > --- a/testcases/kernel/syscalls/ipc/msgstress/msgstress03.c > +++ b/testcases/kernel/syscalls/ipc/msgstress/msgstress03.c > @@ -109,7 +109,7 @@ int main(int argc, char **argv) > } > } > > - free_pids = tst_get_free_pids(cleanup); > + free_pids = tst_get_free_pids(cleanup) / 2; > if (nprocs >= free_pids) { > tst_resm(TINFO, > "Requested number of processes higher than limit (%d > %d), " > -- > 2.25.1
diff --git a/testcases/kernel/syscalls/ipc/msgstress/msgstress03.c b/testcases/kernel/syscalls/ipc/msgstress/msgstress03.c index 3cb70ab18..0c46927b8 100644 --- a/testcases/kernel/syscalls/ipc/msgstress/msgstress03.c +++ b/testcases/kernel/syscalls/ipc/msgstress/msgstress03.c @@ -109,7 +109,7 @@ int main(int argc, char **argv) } } - free_pids = tst_get_free_pids(cleanup); + free_pids = tst_get_free_pids(cleanup) / 2; if (nprocs >= free_pids) { tst_resm(TINFO, "Requested number of processes higher than limit (%d > %d), "
It appears that msgstress03 doesn't account for all PIDs that its children can use, as it expects the tasks will terminate quickly and not reach the PID limit. On some systems, this assumption can be invalid and the PID limit will be hit. Change the limit to account for all possible children at once, knowning that each child will fork as well. Signed-off-by: Teo Couprie Diaz <teo.coupriediaz@arm.com> --- testcases/kernel/syscalls/ipc/msgstress/msgstress03.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)