| Message ID | 20230103124505.6611-1-pvorel@suse.cz |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/2] configure.ac: Require 2.64 | expand |
Hi, tested: https://github.com/pevik/ltp/actions/runs/3829553464 Kind regards, Petr
Hi Petr, I see other places also used 2.61, do you think we need to correct them as well? (e.g. open-posix and realtime) $ git grep AC_PREREQ configure.ac:AC_PREREQ(2.61) testcases/open_posix_testsuite/configure.ac:AC_PREREQ(2.61) testcases/realtime/configure.ac:AC_PREREQ(2.61) On Tue, Jan 3, 2023 at 8:45 PM Petr Vorel <pvorel@suse.cz> wrote: > autoconf 2.64 is required by m4/ax_check_compile_flag.m4 > (for _AC_LANG_PREFIX and AS_VAR_IF). > > Testing on old distro (CentOS 6) with autoconf-2.63-5.1.el6.noarch > make autotools fails: > > aclocal -I m4 > configure.ac:397: error: Autoconf version 2.64 or higher is required > m4/ax_check_compile_flag.m4:39: AX_CHECK_COMPILE_FLAG is expanded from... > configure.ac:397: the top level > autom4te: /usr/bin/m4 failed with exit status: 63 > aclocal: autom4te failed with exit status: 63 > make: *** [aclocal.m4] Error 63 > > Fixes: a08cbaea73 ("Add AX_CHECK_COMPILE_FLAG() autoconf macro") > > Signed-off-by: Petr Vorel <pvorel@suse.cz> > --- > configure.ac | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure.ac b/configure.ac > index 1ab7cc60da..c2b0f48e79 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -1,4 +1,4 @@ > -AC_PREREQ(2.61) > +AC_PREREQ(2.64) > AC_INIT([ltp], [LTP_VERSION], [ltp@lists.linux.it]) > AC_CONFIG_AUX_DIR([.]) > AM_INIT_AUTOMAKE > -- > 2.39.0 > > > -- > Mailing list info: https://lists.linux.it/listinfo/ltp > >
Hi Li, > Hi Petr, > I see other places also used 2.61, do you think we need to correct them as > well? > (e.g. open-posix and realtime) > $ git grep AC_PREREQ > configure.ac:AC_PREREQ(2.61) > testcases/open_posix_testsuite/configure.ac:AC_PREREQ(2.61) > testcases/realtime/configure.ac:AC_PREREQ(2.61) Sure, I could do that, but these independent projects actually work with older version, that's why I didn't do that. FYI realtime will go away, once I find time to port relevant tests to rt_tests and openposix could one day become in separate git. Kind regards, Petr
Petr Vorel <pvorel@suse.cz> wrote: Hi Li, > > > Hi Petr, > > > I see other places also used 2.61, do you think we need to correct them > as > > well? > > (e.g. open-posix and realtime) > > > $ git grep AC_PREREQ > > configure.ac:AC_PREREQ(2.61) > > testcases/open_posix_testsuite/configure.ac:AC_PREREQ(2.61) > > testcases/realtime/configure.ac:AC_PREREQ(2.61) > > Sure, I could do that, but these independent projects actually work with > older > version, that's why I didn't do that. > Ok, as long as we build it internally of LTP, that is required because we have to check the configuration at top-level and then go into the subproject. It will use the upper version first. > > FYI realtime will go away, once I find time to port relevant tests to > rt_tests > and openposix could one day become in separate git. > If so, that older version will be tolerated. Thanks! For both: Reviewed-by: Li Wang <liwang@redhat.com>
Hello, Merged, thanks! Li Wang <liwang@redhat.com> writes: > Petr Vorel <pvorel@suse.cz> wrote: > > Hi Li, >> >> > Hi Petr, >> >> > I see other places also used 2.61, do you think we need to correct them >> as >> > well? >> > (e.g. open-posix and realtime) >> >> > $ git grep AC_PREREQ >> > configure.ac:AC_PREREQ(2.61) >> > testcases/open_posix_testsuite/configure.ac:AC_PREREQ(2.61) >> > testcases/realtime/configure.ac:AC_PREREQ(2.61) >> >> Sure, I could do that, but these independent projects actually work with >> older >> version, that's why I didn't do that. >> > > Ok, as long as we build it internally of LTP, that is required because > we have to check the configuration at top-level and then go into the > subproject. It will use the upper version first. > > >> >> FYI realtime will go away, once I find time to port relevant tests to >> rt_tests >> and openposix could one day become in separate git. >> > > If so, that older version will be tolerated. Thanks! > > For both: > Reviewed-by: Li Wang <liwang@redhat.com> > > -- > Regards, > Li Wang
diff --git a/configure.ac b/configure.ac index 1ab7cc60da..c2b0f48e79 100644 --- a/configure.ac +++ b/configure.ac @@ -1,4 +1,4 @@ -AC_PREREQ(2.61) +AC_PREREQ(2.64) AC_INIT([ltp], [LTP_VERSION], [ltp@lists.linux.it]) AC_CONFIG_AUX_DIR([.]) AM_INIT_AUTOMAKE
autoconf 2.64 is required by m4/ax_check_compile_flag.m4 (for _AC_LANG_PREFIX and AS_VAR_IF). Testing on old distro (CentOS 6) with autoconf-2.63-5.1.el6.noarch make autotools fails: aclocal -I m4 configure.ac:397: error: Autoconf version 2.64 or higher is required m4/ax_check_compile_flag.m4:39: AX_CHECK_COMPILE_FLAG is expanded from... configure.ac:397: the top level autom4te: /usr/bin/m4 failed with exit status: 63 aclocal: autom4te failed with exit status: 63 make: *** [aclocal.m4] Error 63 Fixes: a08cbaea73 ("Add AX_CHECK_COMPILE_FLAG() autoconf macro") Signed-off-by: Petr Vorel <pvorel@suse.cz> --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)