diff mbox series

test_robind.sh: fix BROK: mkfs.f2fs /dev/sdb1 failed

Message ID 20221114062008.999566-1-jie2x.zhou@intel.com
State Accepted
Headers show
Series test_robind.sh: fix BROK: mkfs.f2fs /dev/sdb1 failed | expand

Commit Message

Jie2x Zhou Nov. 14, 2022, 6:20 a.m. UTC
Error output:
test_robind 1 TINFO: Formatting /dev/sda1 with f2fs extra opts=''

        F2FS-tools: mkfs.f2fs Ver: 1.14.0 (2020-08-24)

Info: Disable heap-based policy
Info: Debug level = 0
Info: Trim is enabled
        /dev/sda1 appears to contain an existing filesystem (f2fs).
        Use the -f option to force overwrite.
test_robind 1 TBROK: mkfs.f2fs /dev/sda1 failed

Reason:
Test error is caused by miss "-f" option when do mkfs.f2fs.

Signed-off-by: Jie2x Zhou <jie2x.zhou@intel.com>
---
 testcases/kernel/fs/fs_readonly/test_robind.sh | 2 ++
 1 file changed, 2 insertions(+)

Comments

Richard Palethorpe Nov. 15, 2022, 10:15 a.m. UTC | #1
Hello,

Merged, thanks!

Jie2x Zhou <jie2x.zhou@intel.com> writes:

> Error output:
> test_robind 1 TINFO: Formatting /dev/sda1 with f2fs extra opts=''
>
>         F2FS-tools: mkfs.f2fs Ver: 1.14.0 (2020-08-24)
>
> Info: Disable heap-based policy
> Info: Debug level = 0
> Info: Trim is enabled
>         /dev/sda1 appears to contain an existing filesystem (f2fs).
>         Use the -f option to force overwrite.
> test_robind 1 TBROK: mkfs.f2fs /dev/sda1 failed
>
> Reason:
> Test error is caused by miss "-f" option when do mkfs.f2fs.
>
> Signed-off-by: Jie2x Zhou <jie2x.zhou@intel.com>
> ---
>  testcases/kernel/fs/fs_readonly/test_robind.sh | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/testcases/kernel/fs/fs_readonly/test_robind.sh b/testcases/kernel/fs/fs_readonly/test_robind.sh
> index bab2648f4..2d9a87b7e 100755
> --- a/testcases/kernel/fs/fs_readonly/test_robind.sh
> +++ b/testcases/kernel/fs/fs_readonly/test_robind.sh
> @@ -200,6 +200,8 @@ for fstype in $FSTYPES; do
>  		opts="-F"
>  	elif [ "$fstype" = "xfs" ]; then
>  		opts="-f"
> +	elif [ "$fstype" = "f2fs" ]; then
> +		opts="-f"
>  	elif [ "$fstype" = "btrfs" ]; then
>  		opts="-f"
>  	fi
> -- 
> 2.38.1
diff mbox series

Patch

diff --git a/testcases/kernel/fs/fs_readonly/test_robind.sh b/testcases/kernel/fs/fs_readonly/test_robind.sh
index bab2648f4..2d9a87b7e 100755
--- a/testcases/kernel/fs/fs_readonly/test_robind.sh
+++ b/testcases/kernel/fs/fs_readonly/test_robind.sh
@@ -200,6 +200,8 @@  for fstype in $FSTYPES; do
 		opts="-F"
 	elif [ "$fstype" = "xfs" ]; then
 		opts="-f"
+	elif [ "$fstype" = "f2fs" ]; then
+		opts="-f"
 	elif [ "$fstype" = "btrfs" ]; then
 		opts="-f"
 	fi