Message ID | 20220830123542.1912-1-andrea.cervesato@suse.com |
---|---|
State | Superseded |
Headers | show |
Series | [v1] Improve safe_setxattr error message on ENOTSUP | expand |
Hi, please consider v2 and not this one. Thanks On 8/30/22 14:35, Andrea Cervesato wrote: > According with setxattr manual, ENOTSUP is related also with an > invalid namespace/name format. > > Signed-off-by: Andrea Cervesato <andrea.cervesato@suse.com> > --- > lib/safe_macros.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/safe_macros.c b/lib/safe_macros.c > index a5b6bc504..5671f66fb 100644 > --- a/lib/safe_macros.c > +++ b/lib/safe_macros.c > @@ -1011,7 +1011,7 @@ int safe_setxattr(const char *file, const int lineno, const char *path, > if (rval == -1) { > if (errno == ENOTSUP) { > tst_brkm_(file, lineno, TCONF, NULL, > - "no xattr support in fs or mounted without user_xattr option"); > + "no xattr support in fs, mounted without user_xattr option or bad name format"); > return rval; > } >
diff --git a/lib/safe_macros.c b/lib/safe_macros.c index a5b6bc504..5671f66fb 100644 --- a/lib/safe_macros.c +++ b/lib/safe_macros.c @@ -1011,7 +1011,7 @@ int safe_setxattr(const char *file, const int lineno, const char *path, if (rval == -1) { if (errno == ENOTSUP) { tst_brkm_(file, lineno, TCONF, NULL, - "no xattr support in fs or mounted without user_xattr option"); + "no xattr support in fs, mounted without user_xattr option or bad name format"); return rval; }
According with setxattr manual, ENOTSUP is related also with an invalid namespace/name format. Signed-off-by: Andrea Cervesato <andrea.cervesato@suse.com> --- lib/safe_macros.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)