diff mbox series

[1/2] Add configure check for sys/pidfd.h

Message ID 20220816051539.2948547-1-raj.khem@gmail.com
State Not Applicable
Headers show
Series [1/2] Add configure check for sys/pidfd.h | expand

Commit Message

Khem Raj Aug. 16, 2022, 5:15 a.m. UTC
Use it to include newly added sys/pidfd.h in glibc 2.36+

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 configure.ac         | 1 +
 include/lapi/pidfd.h | 4 ++++
 2 files changed, 5 insertions(+)

Comments

Li Wang Aug. 16, 2022, 6:02 a.m. UTC | #1
Hi Khem,

Did you fetch the latest branch of LTP? if not, can you try with that?

I guess this was duplicated with another fix(merged).
https://github.com/linux-test-project/ltp/commit/dbc9c14c92a5acf450d07868a735ac8cd6ec5b90

and patch2/2 similar to:
https://github.com/linux-test-project/ltp/commit/b857f8723f30a4b9554bf6b0ff8fa52fd07e8b60


On Tue, Aug 16, 2022 at 1:16 PM Khem Raj <raj.khem@gmail.com> wrote:

> Use it to include newly added sys/pidfd.h in glibc 2.36+
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  configure.ac         | 1 +
>  include/lapi/pidfd.h | 4 ++++
>  2 files changed, 5 insertions(+)
>
> diff --git a/configure.ac b/configure.ac
> index 81cba98c2..a0123f166 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -71,6 +71,7 @@ AC_CHECK_HEADERS_ONCE([ \
>      sys/epoll.h \
>      sys/fanotify.h \
>      sys/inotify.h \
> +    sys/pidfd.h \
>      sys/prctl.h \
>      sys/shm.h \
>      sys/timerfd.h \
> diff --git a/include/lapi/pidfd.h b/include/lapi/pidfd.h
> index 244d3acaf..d29a2b274 100644
> --- a/include/lapi/pidfd.h
> +++ b/include/lapi/pidfd.h
> @@ -15,6 +15,10 @@
>  #define PIDFD_NONBLOCK O_NONBLOCK
>  #endif
>
> +#ifdef HAVE_SYS_PIDFD_H
> +#include <sys/pidfd.h>
> +#endif
> +
>  static inline void pidfd_send_signal_supported(void)
>  {
>         /* allow the tests to fail early */
> --
> 2.37.2
>
>
> --
> Mailing list info: https://lists.linux.it/listinfo/ltp
>
>
Yang Xu Aug. 16, 2022, 7:53 a.m. UTC | #2
Hi Li, Khem

> Hi Khem,
> 
> Did you fetch the latest branch of LTP? if not, can you try with that?
> 
> I guess this was duplicated with another fix(merged).
> https://github.com/linux-test-project/ltp/commit/dbc9c14c92a5acf450d07868a735ac8cd6ec5b90 <https://github.com/linux-test-project/ltp/commit/dbc9c14c92a5acf450d07868a735ac8cd6ec5b90>
> 
> and patch2/2 similar to:
> https://github.com/linux-test-project/ltp/commit/b857f8723f30a4b9554bf6b0ff8fa52fd07e8b60
> <https://github.com/linux-test-project/ltp/commit/b857f8723f30a4b9554bf6b0ff8fa52fd07e8b60>
> 
I guess Khem used ltp release version 20220527 then add his own patch[1].
So this patch set should be dropped.

[1]https://github.com/openembedded/openembedded-core/blob/master/meta/recipes-extended/ltp/ltp_20220527.bb

Best Regards
Yang Xu

> 
> On Tue, Aug 16, 2022 at 1:16 PM Khem Raj <raj.khem@gmail.com 
> <mailto:raj.khem@gmail.com>> wrote:
> 
>     Use it to include newly added sys/pidfd.h in glibc 2.36+
> 
>     Signed-off-by: Khem Raj <raj.khem@gmail.com <mailto:raj.khem@gmail.com>>
>     ---
>     configure.ac <http://configure.ac>         | 1 +
>       include/lapi/pidfd.h | 4 ++++
>       2 files changed, 5 insertions(+)
> 
>     diff --git a/configure.ac <http://configure.ac> b/configure.ac
>     <http://configure.ac>
>     index 81cba98c2..a0123f166 100644
>     --- a/configure.ac <http://configure.ac>
>     +++ b/configure.ac <http://configure.ac>
>     @@ -71,6 +71,7 @@ AC_CHECK_HEADERS_ONCE([ \
>           sys/epoll.h \
>           sys/fanotify.h \
>           sys/inotify.h \
>     +    sys/pidfd.h \
>           sys/prctl.h \
>           sys/shm.h \
>           sys/timerfd.h \
>     diff --git a/include/lapi/pidfd.h b/include/lapi/pidfd.h
>     index 244d3acaf..d29a2b274 100644
>     --- a/include/lapi/pidfd.h
>     +++ b/include/lapi/pidfd.h
>     @@ -15,6 +15,10 @@
>       #define PIDFD_NONBLOCK O_NONBLOCK
>       #endif
> 
>     +#ifdef HAVE_SYS_PIDFD_H
>     +#include <sys/pidfd.h>
>     +#endif
>     +
>       static inline void pidfd_send_signal_supported(void)
>       {
>              /* allow the tests to fail early */
>     -- 
>     2.37.2
> 
> 
>     -- 
>     Mailing list info: https://lists.linux.it/listinfo/ltp
>     <https://lists.linux.it/listinfo/ltp>
> 
> 
> 
> -- 
> Regards,
> Li Wang
> 
>
diff mbox series

Patch

diff --git a/configure.ac b/configure.ac
index 81cba98c2..a0123f166 100644
--- a/configure.ac
+++ b/configure.ac
@@ -71,6 +71,7 @@  AC_CHECK_HEADERS_ONCE([ \
     sys/epoll.h \
     sys/fanotify.h \
     sys/inotify.h \
+    sys/pidfd.h \
     sys/prctl.h \
     sys/shm.h \
     sys/timerfd.h \
diff --git a/include/lapi/pidfd.h b/include/lapi/pidfd.h
index 244d3acaf..d29a2b274 100644
--- a/include/lapi/pidfd.h
+++ b/include/lapi/pidfd.h
@@ -15,6 +15,10 @@ 
 #define PIDFD_NONBLOCK O_NONBLOCK
 #endif
 
+#ifdef HAVE_SYS_PIDFD_H
+#include <sys/pidfd.h>
+#endif
+
 static inline void pidfd_send_signal_supported(void)
 {
 	/* allow the tests to fail early */