| Message ID | 20220808071439.741-2-pvorel@suse.cz |
|---|---|
| State | Accepted |
| Headers | show |
| Series | github pull request template | expand |
Hi! > Create pull request template to inform people that we prefer patches to > our mailing list. We have this info in README.md, but even experienced, > who send patches with git send-email to other projects overlook this > info and open github pull requests. > > While at it, add links to the test case tutorial, lore and patchwork. > > Template does not support any formatting, therefore using plain links. > > Signed-off-by: Petr Vorel <pvorel@suse.cz> > --- > NOTE: you can test it if you fork from my fork: > https://github.com/pevik/ltp > > .github/pull_request_template.md | 6 ++++++ > 1 file changed, 6 insertions(+) > create mode 100644 .github/pull_request_template.md > > diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md > new file mode 100644 > index 000000000..68c8a6499 > --- /dev/null > +++ b/.github/pull_request_template.md > @@ -0,0 +1,6 @@ > +Although we *occasionally* also accept GitHub pull requests, the *preferred* way is sending patches to our mailing list: https://lore.kernel.org/ltp/ > + > +There is an example how to use it: https://github.com/linux-test-project/ltp/wiki/C-Test-Case-Tutorial#7-submitting-the-test-for-review (using git format-patch and git send-email). > + > +LTP mailing list is archived: https://lore.kernel.org/ltp/. ^ archived at: > +We also have a patchwork instance: https://patchwork.ozlabs.org/project/ltp/list/. So this text is filled in the pull request as a message when user creates it, right? I guess that this is a creative misuse but I kind of like it :-). Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
> Hi! > > Create pull request template to inform people that we prefer patches to > > our mailing list. We have this info in README.md, but even experienced, > > who send patches with git send-email to other projects overlook this > > info and open github pull requests. > > While at it, add links to the test case tutorial, lore and patchwork. > > Template does not support any formatting, therefore using plain links. > > Signed-off-by: Petr Vorel <pvorel@suse.cz> > > --- > > NOTE: you can test it if you fork from my fork: > > https://github.com/pevik/ltp > > .github/pull_request_template.md | 6 ++++++ > > 1 file changed, 6 insertions(+) > > create mode 100644 .github/pull_request_template.md > > diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md > > new file mode 100644 > > index 000000000..68c8a6499 > > --- /dev/null > > +++ b/.github/pull_request_template.md > > @@ -0,0 +1,6 @@ > > +Although we *occasionally* also accept GitHub pull requests, the *preferred* way is sending patches to our mailing list: https://lore.kernel.org/ltp/ > > + > > +There is an example how to use it: https://github.com/linux-test-project/ltp/wiki/C-Test-Case-Tutorial#7-submitting-the-test-for-review (using git format-patch and git send-email). > > + > > +LTP mailing list is archived: https://lore.kernel.org/ltp/. > ^ > archived at: Ah, my poor English, I didn't know 'at' is mandatory. > > +We also have a patchwork instance: https://patchwork.ozlabs.org/project/ltp/list/. > So this text is filled in the pull request as a message when user > creates it, right? Yes :). > I guess that this is a creative misuse but I kind of like it :-). Thx! > Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
> So this text is filled in the pull request as a message when user > creates it, right? > I guess that this is a creative misuse but I kind of like it :-). BTW lazy reporters can just click on preview to get formatting + working symlinks :). Petr
diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md new file mode 100644 index 000000000..68c8a6499 --- /dev/null +++ b/.github/pull_request_template.md @@ -0,0 +1,6 @@ +Although we *occasionally* also accept GitHub pull requests, the *preferred* way is sending patches to our mailing list: https://lore.kernel.org/ltp/ + +There is an example how to use it: https://github.com/linux-test-project/ltp/wiki/C-Test-Case-Tutorial#7-submitting-the-test-for-review (using git format-patch and git send-email). + +LTP mailing list is archived: https://lore.kernel.org/ltp/. +We also have a patchwork instance: https://patchwork.ozlabs.org/project/ltp/list/.