diff mbox series

dup204.c: use TST_EXP_VAL() and TST_EXP_EQ_LU() macros

Message ID 20220726091528.29864-1-akumar@suse.de
State Accepted
Headers show
Series dup204.c: use TST_EXP_VAL() and TST_EXP_EQ_LU() macros | expand

Commit Message

Avinesh Kumar July 26, 2022, 9:15 a.m. UTC 
Signed-off-by: Avinesh Kumar <akumar@suse.de>
---
 testcases/kernel/syscalls/dup2/dup204.c | 15 +++------------
 1 file changed, 3 insertions(+), 12 deletions(-)

Comments

Petr Vorel Aug. 2, 2022, 5:19 p.m. UTC | #1 
Hi Avinesh,

merged, thanks!

Kind regards,
Petr
diff mbox series

Patch

diff --git a/testcases/kernel/syscalls/dup2/dup204.c b/testcases/kernel/syscalls/dup2/dup204.c
index 0fb6b0dc2..112ce0c9d 100644
--- a/testcases/kernel/syscalls/dup2/dup204.c
+++ b/testcases/kernel/syscalls/dup2/dup204.c
@@ -35,23 +35,14 @@  static void run(unsigned int i)
 {
 	struct stat oldbuf, newbuf;
 
-	TEST(dup2(fd[i], nfd[i]));
-	if (TST_RET == -1) {
-		tst_res(TFAIL, "call failed unexpectedly");
+	TST_EXP_VAL(dup2(fd[i], nfd[i]), nfd[i]);
+	if (TST_RET == -1)
 		return;
-	}
 
 	SAFE_FSTAT(fd[i], &oldbuf);
 	SAFE_FSTAT(nfd[i], &newbuf);
 
-	if (oldbuf.st_ino != newbuf.st_ino)
-		tst_res(TFAIL,
-			"original inode(%ld) and duped inode(%ld) do not match",
-			oldbuf.st_ino, newbuf.st_ino);
-	else
-		tst_res(TPASS,
-			"original inode(%ld) and duped inode(%ld) are the same",
-			oldbuf.st_ino, newbuf.st_ino);
+	TST_EXP_EQ_LU(oldbuf.st_ino, newbuf.st_ino);
 
 	SAFE_CLOSE(TST_RET);
 }