| Message ID | 20220401084124.801586-1-liwang@redhat.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | ci: resolve some no match arguments problem | expand |
Hi Li,
Acked-by: Petr Vorel <pvorel@suse.cz>
Thanks!
I suppose this fix is for local run of this script on RHEL VM, right?
Or is there some failure in CI I overlooked?
Kind regards,
Petr
Hi Li,
> Make this installation can succeed on all RHEL related platforms.
BTW Other alternative would be to move these packages to the end, i.e.:
$yum foo || true
Because with this, we might put rubygem-asciidoctor also to main $yum command
(it should now work with --skip-broken
Kind regards,
Petr
On Fri, Apr 1, 2022 at 5:16 PM Petr Vorel <pvorel@suse.cz> wrote: > Hi Li, > > Acked-by: Petr Vorel <pvorel@suse.cz> > Thanks! > > I suppose this fix is for local run of this script on RHEL VM, right? > That's right. Pushed. > Or is there some failure in CI I overlooked? > > No failures from CI, it is just to make the installation easier everywhere :).
> BTW Other alternative would be to move these packages to the end, i.e.: > $yum foo || true > > Because with this, we might put rubygem-asciidoctor also to main $yum > command > (it should now work with --skip-broken Yes, good point.
diff --git a/ci/fedora.sh b/ci/fedora.sh index dc1293aa5..a603bcbe3 100755 --- a/ci/fedora.sh +++ b/ci/fedora.sh @@ -2,7 +2,7 @@ # Copyright (c) 2018-2021 Petr Vorel <pvorel@suse.cz> set -ex -yum="yum -y install" +yum="yum -y install --skip-broken" $yum \ asciidoc \
Make this installation can succeed on all RHEL related platforms. Signed-off-by: Li Wang <liwang@redhat.com> --- ci/fedora.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)