diff mbox series

[v2,3/3] getrusage03, setsockopt03: Add sentinel value to tags

Message ID 20211207102904.6011-3-rpalethorpe@suse.com
State Accepted
Headers show
Series [v2,1/3] doc: Add LTP-005: Array must be sentinel terminated | expand

Commit Message

Richard Palethorpe Dec. 7, 2021, 10:29 a.m. UTC
LTP-005

Signed-off-by: Richard Palethorpe <rpalethorpe@suse.com>
---
 testcases/kernel/syscalls/getrusage/getrusage03.c   | 1 +
 testcases/kernel/syscalls/setsockopt/setsockopt03.c | 1 +
 2 files changed, 2 insertions(+)

Comments

Cyril Hrubis Dec. 7, 2021, 10:55 a.m. UTC | #1
Hi!
Looks obviously fine:

Reviewed-by: Cyril Hrubis <chrubis@suse.cz>

Also good catch, this really shows that the automation is worth the
effort.
Richard Palethorpe Dec. 7, 2021, 11:31 a.m. UTC | #2
Hello,

Cyril Hrubis <chrubis@suse.cz> writes:

> Hi!
> Looks obviously fine:
>
> Reviewed-by: Cyril Hrubis <chrubis@suse.cz>

Pushed! Thanks!

>
> Also good catch, this really shows that the automation is worth the
> effort.

I hope so and perhaps this can be generalised by creating an attribute
e.g. (null_terminated) which could be upstreamed to Sparse. Then
eventually it might be adopted by compilers.
diff mbox series

Patch

diff --git a/testcases/kernel/syscalls/getrusage/getrusage03.c b/testcases/kernel/syscalls/getrusage/getrusage03.c
index ef2f62a18..bf5127483 100644
--- a/testcases/kernel/syscalls/getrusage/getrusage03.c
+++ b/testcases/kernel/syscalls/getrusage/getrusage03.c
@@ -180,6 +180,7 @@  static struct tst_test test = {
 	.min_kver = "2.6.32",
 	.tags = (const struct tst_tag[]) {
 		{"linux-git", "1f10206cf8e9"},
+		{}
 	},
 	.test = run,
 	.tcnt = ARRAY_SIZE(testfunc_list),
diff --git a/testcases/kernel/syscalls/setsockopt/setsockopt03.c b/testcases/kernel/syscalls/setsockopt/setsockopt03.c
index b7a4447ba..191c4cdfe 100644
--- a/testcases/kernel/syscalls/setsockopt/setsockopt03.c
+++ b/testcases/kernel/syscalls/setsockopt/setsockopt03.c
@@ -81,5 +81,6 @@  static struct tst_test test = {
 	.tags = (const struct tst_tag[]){
 		{"linux-git", "ce683e5f9d04"},
 		{"CVE", "CVE-2016-4997"},
+		{}
 	}
 };