diff mbox series

[01/12] posix/pthread_create/15-1: Supress warning

Message ID 20211119074602.857595-2-lkml@jv-coder.de
State Accepted
Headers show
Series Fix or suppress compiler warnings in posix/conformance/interfaces | expand

Commit Message

Joerg Vehlow Nov. 19, 2021, 7:45 a.m. UTC 
From: Joerg Vehlow <joerg.vehlow@aox-tech.de>

generate-makefiles.sh gave the following warning:
conformance/interfaces/pthread_create/15-1.c should be test.

The script has a strange implementation, that just greps for "main" in the c file.
Based on that it decides if the file should be a test or a run-test.
Other tests in the suite including the main-function from testfrmw/threads_scenarii.c
also use a comment, that supresses the message

Signed-off-by: Joerg Vehlow <joerg.vehlow@aox-tech.de>
---
 .../conformance/interfaces/pthread_create/15-1.c                 | 1 +
 1 file changed, 1 insertion(+)

Comments

Cyril Hrubis Nov. 19, 2021, 2:34 p.m. UTC | #1 
Hi!
> The script has a strange implementation, that just greps for "main" in the c file.
> Based on that it decides if the file should be a test or a run-test.
> Other tests in the suite including the main-function from testfrmw/threads_scenarii.c
> also use a comment, that supresses the message

I think that the testfrmw should be cleaned up and rewritten or even
better we should get rid of it completely in the long term...

Anyways applied, since this is simple enough.
diff mbox series

Patch

diff --git a/testcases/open_posix_testsuite/conformance/interfaces/pthread_create/15-1.c b/testcases/open_posix_testsuite/conformance/interfaces/pthread_create/15-1.c
index e8c003fd4..a05db679b 100644
--- a/testcases/open_posix_testsuite/conformance/interfaces/pthread_create/15-1.c
+++ b/testcases/open_posix_testsuite/conformance/interfaces/pthread_create/15-1.c
@@ -76,6 +76,7 @@ 
 /***********************************    Test cases  *****************************************/
 /********************************************************************************************/
 
+/* main is defined in the next file */
 #define STD_MAIN
 #include "../testfrmw/threads_scenarii.c"