diff mbox series

[RFC,v2,1/3] tst_netdevice.c: Drop redundant include

Message ID 20210930183058.5240-2-petr.vorel@gmail.com
State Accepted
Headers show
Series Fix old toolchain (< v3.14) | expand

Commit Message

Petr Vorel Sept. 30, 2021, 6:30 p.m. UTC 
<linux/rtnetlink.h> is already included in lapi/rtnetlink.h.

Signed-off-by: Petr Vorel <petr.vorel@gmail.com>
---
 lib/tst_netdevice.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Cyril Hrubis Oct. 6, 2021, 1:51 p.m. UTC | #1 
Hi!
> <linux/rtnetlink.h> is already included in lapi/rtnetlink.h.
                     ^
		     which includes <linux/netlink.h>

I suppose that you have tested this in CI and that it works fine. If
that is so:

Acked-by: Cyril Hrubis <chrubis@suse.cz>

> Signed-off-by: Petr Vorel <petr.vorel@gmail.com>
> ---
>  lib/tst_netdevice.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/lib/tst_netdevice.c b/lib/tst_netdevice.c
> index ba9a55b70..4a0442932 100644
> --- a/lib/tst_netdevice.c
> +++ b/lib/tst_netdevice.c
> @@ -4,7 +4,6 @@
>   */
>  
>  #include <asm/types.h>
> -#include <linux/netlink.h>
>  #include <linux/veth.h>
>  #include <sys/socket.h>
>  #include <net/if.h>
> -- 
> 2.33.0
>
diff mbox series

Patch

diff --git a/lib/tst_netdevice.c b/lib/tst_netdevice.c
index ba9a55b70..4a0442932 100644
--- a/lib/tst_netdevice.c
+++ b/lib/tst_netdevice.c
@@ -4,7 +4,6 @@ 
  */
 
 #include <asm/types.h>
-#include <linux/netlink.h>
 #include <linux/veth.h>
 #include <sys/socket.h>
 #include <net/if.h>