| Message ID | 20210816111651.29860-2-rpalethorpe@suse.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v4,1/2] setsockopt08: Handle ENOPROTOOPT even with compatible config | expand |
On 16. 08. 21 13:16, Richard Palethorpe via ltp wrote: > When not in compat mode this only tests that bad offsets result in > EINVAL. When in compat mode, we also test for the vulnerability. > > Therefor I view this as two tests. The TCONF was supposed to indicate > the configuration didn't allow one of these tests. However it just > caused confusion with multiple people asking me to change it to > tst_brk. > > So change it to TINFO. > > Signed-off-by: Richard Palethorpe <rpalethorpe@suse.com> > --- Hi, for both patches: Reviewed-by: Martin Doucha <mdoucha@suse.cz>
Hi Richie, Martin, Thanks both, patchset merged. Kind regards, Petr
diff --git a/testcases/kernel/syscalls/setsockopt/setsockopt08.c b/testcases/kernel/syscalls/setsockopt/setsockopt08.c index 20abe85b4..1ffc69178 100644 --- a/testcases/kernel/syscalls/setsockopt/setsockopt08.c +++ b/testcases/kernel/syscalls/setsockopt/setsockopt08.c @@ -91,7 +91,7 @@ static void *buffer; void setup(void) { if (tst_kernel_bits() == 32 || sizeof(long) > 4) { - tst_res(TCONF, + tst_res(TINFO, "The vulnerability was only present in 32-bit compat mode"); }
When not in compat mode this only tests that bad offsets result in EINVAL. When in compat mode, we also test for the vulnerability. Therefor I view this as two tests. The TCONF was supposed to indicate the configuration didn't allow one of these tests. However it just caused confusion with multiple people asking me to change it to tst_brk. So change it to TINFO. Signed-off-by: Richard Palethorpe <rpalethorpe@suse.com> --- testcases/kernel/syscalls/setsockopt/setsockopt08.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)