diff mbox series

[v2,2/2] proc01: remove unused lsm_should_work (-Wunused-const-variable)

Message ID 20210701131427.72574-2-krzysztof.kozlowski@canonical.com
State Accepted
Headers show
Series [v2,1/2] proc01: fix selinux attributes without libselinux-dev | expand

Commit Message

Krzysztof Kozlowski July 1, 2021, 1:14 p.m. UTC 
Recent refactoring made the "lsm_should_work" unused without
libselinux-dev:

    proc01.c:142:19: warning: ‘lsm_should_work’ defined but not used [-Wunused-const-variable=]

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>

---

Changes since v1:
1. Fixup part of #1 patch.
---
 testcases/kernel/fs/proc/proc01.c | 6 ------
 1 file changed, 6 deletions(-)

Comments

Petr Vorel July 12, 2021, 8:59 a.m. UTC | #1 
Hi Krzysztof,

Reviewed-by: Petr Vorel <pvorel@suse.cz>

Kind regards,
Petr
Petr Vorel July 12, 2021, 12:27 p.m. UTC | #2 
Hi Krzysztof,

whole patchset merged.

Kind regards,
Petr
diff mbox series

Patch

diff --git a/testcases/kernel/fs/proc/proc01.c b/testcases/kernel/fs/proc/proc01.c
index 6ddb6682f38b..c90e509a3243 100644
--- a/testcases/kernel/fs/proc/proc01.c
+++ b/testcases/kernel/fs/proc/proc01.c
@@ -140,12 +140,6 @@  static const char lsm_should_work[][PATH_MAX] = {
 	"/proc/self/task/[0-9]*/attr/selinux/*",
 	""
 };
-
-/* Place holder for none of LSM is detected. */
-#else
-static const char lsm_should_work[][PATH_MAX] = {
-	""
-};
 #endif
 
 /* Known files that does not honor O_NONBLOCK, so they will hang