diff mbox series

Set exfat file system to skip symlink

Message ID 20210428025039.14351-1-zhanglianjie@uniontech.com
State Accepted
Headers show
Series Set exfat file system to skip symlink | expand

Commit Message

zhanglianjie April 28, 2021, 2:50 a.m. UTC 
If the kernel configuration CONF_EXFAT_FS=m, then the exfat test
result is TCONF. If the kernel is not configured with CONF_EXFAT_FS=m,
then the exfat test result will be TBROK (TBROK makes subsequent tests
impossible). Because the exfat file system does not support symlink,
the test should skip calling symlink.

Signed-off-by: zhanglianjie <zhanglianjie@uniontech.com>
---
 testcases/kernel/syscalls/chdir/chdir01.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
2.20.1

Comments

Petr Vorel April 28, 2021, 7:03 p.m. UTC | #1 
Hi,

good catch!

> If the kernel configuration CONF_EXFAT_FS=m, then the exfat test
you mean CONFIG_EXFAT_FS.

> result is TCONF. If the kernel is not configured with CONF_EXFAT_FS=m,
> then the exfat test result will be TBROK (TBROK makes subsequent tests
> impossible). Because the exfat file system does not support symlink,
> the test should skip calling symlink.

I reword the commit message and merged.
Thanks!

Kind regards,
Petr
diff mbox series

Patch

diff --git a/testcases/kernel/syscalls/chdir/chdir01.c b/testcases/kernel/syscalls/chdir/chdir01.c
index 23cd455d6..aa25adf6a 100644
--- a/testcases/kernel/syscalls/chdir/chdir01.c
+++ b/testcases/kernel/syscalls/chdir/chdir01.c
@@ -69,7 +69,7 @@  static void setup(void)

 	if (!TST_RET)
 		SAFE_SYMLINK(LINK_NAME2, LINK_NAME1);
-	else if (TST_RET == -1 && TST_ERR == EPERM)
+	else if (TST_RET == -1 && (TST_ERR == EPERM || TST_ERR == ENOSYS))
 		skip_symlinks = 1;
 	else
 		tst_brk(TBROK | TTERRNO, "Cannot create symlinks");