| Message ID | 20210301220222.22705-8-pvorel@suse.cz |
|---|---|
| State | Superseded |
| Headers | show |
| Series | zram cleanup, tst_set_timeout(timeout) | expand |
On Tue, Mar 2, 2021 at 6:02 AM Petr Vorel <pvorel@suse.cz> wrote: > to avoid unexpected timeout, which occurred even on just 4 zram devices. > > On my system where run with ext{2,3,4}, xfs, btrfs, vfat, exfat, ntfs > it run for 12 min, i.e. mean 90s. Multiply by security constant 5, > expecting 450 sec for each filesystem. > > Signed-off-by: Petr Vorel <pvorel@suse.cz> > Reviewed-by: Li Wang <liwang@redhat.com> Apart from the two places(patch 5/7, 6/7) that need tweaking/discussion, the patches look good.
Hi!
Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
diff --git a/testcases/kernel/device-drivers/zram/zram_lib.sh b/testcases/kernel/device-drivers/zram/zram_lib.sh index 65e431e86..fe9c915c3 100755 --- a/testcases/kernel/device-drivers/zram/zram_lib.sh +++ b/testcases/kernel/device-drivers/zram/zram_lib.sh @@ -47,6 +47,8 @@ zram_load() tst_brk TBROK "dev_num must be > 0" fi + tst_set_timeout $((dev_num*450)) + tst_res TINFO "create '$dev_num' zram device(s)" modprobe zram num_devices=$dev_num || \
to avoid unexpected timeout, which occurred even on just 4 zram devices. On my system where run with ext{2,3,4}, xfs, btrfs, vfat, exfat, ntfs it run for 12 min, i.e. mean 90s. Multiply by security constant 5, expecting 450 sec for each filesystem. Signed-off-by: Petr Vorel <pvorel@suse.cz> --- Changes v2->v3: * increase timeout based on measurement (Cyril) testcases/kernel/device-drivers/zram/zram_lib.sh | 2 ++ 1 file changed, 2 insertions(+)