diff mbox series

Reduce writev03 fuzzy_sync timeout

Message ID 20210225140925.16187-1-mdoucha@suse.cz
State Accepted
Headers show
Series Reduce writev03 fuzzy_sync timeout | expand

Commit Message

Martin Doucha Feb. 25, 2021, 2:09 p.m. UTC
Writev03 is fairly slow and tests multiple filesystems, each getting another
round of timeout. Reduce fuzzy sync time limit to 25% of standard timeout
to make the test finish slightly faster.

Signed-off-by: Martin Doucha <mdoucha@suse.cz>
---
 testcases/kernel/syscalls/writev/writev03.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Petr Vorel Feb. 25, 2021, 6:45 p.m. UTC | #1
Hi Martin,

> Writev03 is fairly slow and tests multiple filesystems, each getting another
> round of timeout. Reduce fuzzy sync time limit to 25% of standard timeout
> to make the test finish slightly faster.

> Signed-off-by: Martin Doucha <mdoucha@suse.cz>

LGTM
Reviewed-by: Petr Vorel <pvorel@suse.cz>
> ---
>  testcases/kernel/syscalls/writev/writev03.c | 1 +
>  1 file changed, 1 insertion(+)

> diff --git a/testcases/kernel/syscalls/writev/writev03.c b/testcases/kernel/syscalls/writev/writev03.c
> index 4dc55c191..6514404e6 100644
> --- a/testcases/kernel/syscalls/writev/writev03.c
> +++ b/testcases/kernel/syscalls/writev/writev03.c
> @@ -49,6 +49,7 @@ static void setup(void)
>  	mapfd = SAFE_OPEN(MAPFILE, O_CREAT|O_RDWR|O_TRUNC, 0644);
>  	SAFE_WRITE(1, mapfd, buf, BUF_SIZE);

> +	fzsync_pair.exec_time_p = 0.25;
>  	tst_fzsync_pair_init(&fzsync_pair);
>  }
Richard Palethorpe Feb. 26, 2021, 8 a.m. UTC | #2
Hello,

Martin Doucha <mdoucha@suse.cz> writes:

> Writev03 is fairly slow and tests multiple filesystems, each getting another
> round of timeout. Reduce fuzzy sync time limit to 25% of standard timeout
> to make the test finish slightly faster.
>
> Signed-off-by: Martin Doucha <mdoucha@suse.cz>
> ---
>  testcases/kernel/syscalls/writev/writev03.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/testcases/kernel/syscalls/writev/writev03.c b/testcases/kernel/syscalls/writev/writev03.c
> index 4dc55c191..6514404e6 100644
> --- a/testcases/kernel/syscalls/writev/writev03.c
> +++ b/testcases/kernel/syscalls/writev/writev03.c
> @@ -49,6 +49,7 @@ static void setup(void)
>  	mapfd = SAFE_OPEN(MAPFILE, O_CREAT|O_RDWR|O_TRUNC, 0644);
>  	SAFE_WRITE(1, mapfd, buf, BUF_SIZE);
>  
> +	fzsync_pair.exec_time_p = 0.25;
>  	tst_fzsync_pair_init(&fzsync_pair);
>  }
>  
> -- 
> 2.30.0

LGTM.
Li Wang March 1, 2021, 7:25 a.m. UTC | #3
Patch applied, thanks!
diff mbox series

Patch

diff --git a/testcases/kernel/syscalls/writev/writev03.c b/testcases/kernel/syscalls/writev/writev03.c
index 4dc55c191..6514404e6 100644
--- a/testcases/kernel/syscalls/writev/writev03.c
+++ b/testcases/kernel/syscalls/writev/writev03.c
@@ -49,6 +49,7 @@  static void setup(void)
 	mapfd = SAFE_OPEN(MAPFILE, O_CREAT|O_RDWR|O_TRUNC, 0644);
 	SAFE_WRITE(1, mapfd, buf, BUF_SIZE);
 
+	fzsync_pair.exec_time_p = 0.25;
 	tst_fzsync_pair_init(&fzsync_pair);
 }