| Message ID | 20210120143723.26483-8-rpalethorpe@suse.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Convert CAN tests to new LTP API | expand |
On 20.01.21 15:37, Richard Palethorpe wrote: > socketcan-users appears to be no more. > > Signed-off-by: Richard Palethorpe <rpalethorpe@suse.com> Thanks for the cleanup and the rework, Richard! Acked-by: Oliver Hartkopp <socketcan@hartkopp.net> (for the entire series) Best regards, Oliver > --- > testcases/network/can/filter-tests/00_Descriptions.txt | 5 +++-- > testcases/network/can/filter-tests/Makefile | 2 -- > 2 files changed, 3 insertions(+), 4 deletions(-) > > diff --git a/testcases/network/can/filter-tests/00_Descriptions.txt b/testcases/network/can/filter-tests/00_Descriptions.txt > index 55d213456..9623d29a0 100644 > --- a/testcases/network/can/filter-tests/00_Descriptions.txt > +++ b/testcases/network/can/filter-tests/00_Descriptions.txt > @@ -6,5 +6,6 @@ information on the CAN network protocol family PF_CAN is contained in > > For any issue(s) with CAN tests please write to: > <ltp@lists.linux.it> > -<socketcan-users@lists.berlios.de>, > -Oliver Hartkopp <oliver.hartkopp@volkswagen.de>, > +Oliver Hartkopp <socketcan@hartkopp.net> > +Linux-CAN ML <linux-can@vger.kernel.org> > + > diff --git a/testcases/network/can/filter-tests/Makefile b/testcases/network/can/filter-tests/Makefile > index 29aaa3240..bd57c7fff 100644 > --- a/testcases/network/can/filter-tests/Makefile > +++ b/testcases/network/can/filter-tests/Makefile > @@ -14,8 +14,6 @@ > # You should have received a copy of the GNU General Public License along > # with this program; if not, write to the Free Software Foundation, Inc., > # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. > -# > -# Send feedback to <socketcan-users@lists.berlios.de> > > top_srcdir ?= ../../../.. > >
Hi!
Minus the runtest files that has to be updated the rest looks ok.
Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
Also I do wonder how much of can functionality these tests does not cover.
I guess that we can as well write a test that would add two or more
virtual devices setup routing and send messages between these.
Also there seems to be several different protocols and we seem to be
using only CAN_RAW.
There seems to be also flag to inverse the filter mask with
CAN_INV_FILTER, filter only for error messages and so on.
diff --git a/testcases/network/can/filter-tests/00_Descriptions.txt b/testcases/network/can/filter-tests/00_Descriptions.txt index 55d213456..9623d29a0 100644 --- a/testcases/network/can/filter-tests/00_Descriptions.txt +++ b/testcases/network/can/filter-tests/00_Descriptions.txt @@ -6,5 +6,6 @@ information on the CAN network protocol family PF_CAN is contained in For any issue(s) with CAN tests please write to: <ltp@lists.linux.it> -<socketcan-users@lists.berlios.de>, -Oliver Hartkopp <oliver.hartkopp@volkswagen.de>, +Oliver Hartkopp <socketcan@hartkopp.net> +Linux-CAN ML <linux-can@vger.kernel.org> + diff --git a/testcases/network/can/filter-tests/Makefile b/testcases/network/can/filter-tests/Makefile index 29aaa3240..bd57c7fff 100644 --- a/testcases/network/can/filter-tests/Makefile +++ b/testcases/network/can/filter-tests/Makefile @@ -14,8 +14,6 @@ # You should have received a copy of the GNU General Public License along # with this program; if not, write to the Free Software Foundation, Inc., # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. -# -# Send feedback to <socketcan-users@lists.berlios.de> top_srcdir ?= ../../../..
socketcan-users appears to be no more. Signed-off-by: Richard Palethorpe <rpalethorpe@suse.com> --- testcases/network/can/filter-tests/00_Descriptions.txt | 5 +++-- testcases/network/can/filter-tests/Makefile | 2 -- 2 files changed, 3 insertions(+), 4 deletions(-)