From patchwork Fri Nov 13 15:51:23 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Petr Vorel X-Patchwork-Id: 1399887 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it (client-ip=2001:1418:10:5::2; helo=picard.linux.it; envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=suse.cz Received: from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4CXjdd0gGMz9sT6 for ; Sat, 14 Nov 2020 02:52:04 +1100 (AEDT) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id C30673C5FDA for ; Fri, 13 Nov 2020 16:52:01 +0100 (CET) X-Original-To: ltp@lists.linux.it Delivered-To: ltp@picard.linux.it Received: from in-2.smtp.seeweb.it (in-2.smtp.seeweb.it [IPv6:2001:4b78:1:20::2]) by picard.linux.it (Postfix) with ESMTP id 811D03C2EBE for ; Fri, 13 Nov 2020 16:51:35 +0100 (CET) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by in-2.smtp.seeweb.it (Postfix) with ESMTPS id 22454601D4B for ; Fri, 13 Nov 2020 16:51:35 +0100 (CET) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id A54A6ABD9; Fri, 13 Nov 2020 15:51:34 +0000 (UTC) From: Petr Vorel To: ltp@lists.linux.it Date: Fri, 13 Nov 2020 16:51:23 +0100 Message-Id: <20201113155123.5959-6-pvorel@suse.cz> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201113155123.5959-1-pvorel@suse.cz> References: <20201113155123.5959-1-pvorel@suse.cz> MIME-Version: 1.0 X-Virus-Scanned: clamav-milter 0.102.4 at in-2.smtp.seeweb.it X-Virus-Status: Clean X-Spam-Status: No, score=0.0 required=7.0 tests=SPF_HELO_NONE,SPF_PASS autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on in-2.smtp.seeweb.it Subject: [LTP] [PATCH v2 5/5] fanotify: Add a pedantic check for return value X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it Sender: "ltp" for fanotify_init() in safe_fanotify_init() Signed-off-by: Petr Vorel --- New in v2. FYI We agreed in LTP to test these. testcases/kernel/syscalls/fanotify/fanotify.h | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/testcases/kernel/syscalls/fanotify/fanotify.h b/testcases/kernel/syscalls/fanotify/fanotify.h index 277760c09..f3c2d48b3 100644 --- a/testcases/kernel/syscalls/fanotify/fanotify.h +++ b/testcases/kernel/syscalls/fanotify/fanotify.h @@ -67,6 +67,11 @@ int safe_fanotify_init(const char *file, const int lineno, tst_brk(TBROK | TERRNO, "%s:%d: fanotify_init() failed", file, lineno); } + + if (rval < -1) { + tst_brk(TBROK | TERRNO, "%s:%d: invalid fanotify_init() return %d", + file, lineno, rval); + } #else tst_brk(TCONF, "Header is not present"); #endif /* HAVE_SYS_FANOTIFY_H */